From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Fri, 22 Sep 2023 17:57:30 +0300 Message-ID: <83pm2a5k85.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <72c93fb0-bf3e-3dad-69c0-2147cfa40f57@gutov.dev> <875y42xyex.fsf@localhost> <87zg1ewfc2.fsf@localhost> <834jjm749q.fsf@gnu.org> <87cyyawd1a.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 16:58:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjhbf-0005BU-9b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 16:58:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjhbN-0008N0-RU; Fri, 22 Sep 2023 10:57:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjhbL-0008Mq-PI for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 10:57:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjhbL-0001ml-HR for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 10:57:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjhbV-0003Qa-PK for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 10:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.169539466713155 (code B ref 66117); Fri, 22 Sep 2023 14:58:01 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 22 Sep 2023 14:57:47 +0000 Original-Received: from localhost ([127.0.0.1]:37073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjhbG-0003Q6-O3 for submit@debbugs.gnu.org; Fri, 22 Sep 2023 10:57:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjhbC-0003Pr-G8 for 66117@debbugs.gnu.org; Fri, 22 Sep 2023 10:57:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjhav-0001kB-BZ; Fri, 22 Sep 2023 10:57:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DPnIg5y53lo1bzlt7+vVS+9RHWAJJybXs+iRGXyOhKA=; b=K3Gb7hbD5Iaa hHdkM/PLniwtOv/cg5R+DxdDNRZAQ7YVoNwj6vFqfD/rM1ln+L4/snO+UM7vUmILPiudyYDiQK8Jv AE5n8X/uD/JN8CJWR1CIEGRe4yQMuGK5wXDmhou4RZDgFJAFps4cgHd+8vEUP9bkN7ZpS8DLHqFL9 OnCTf02s4qI9CH0V9LZnvAraf48MEvaD4Yx+krZBwq3eEuTpdsXKXjpWyD4mUilpQUJQKQuP40a2y ralJ1QmeZ7+zF40RgaY0vBs/94QOo0e2oHGKacJCIhKwotKJPNtaBkm8wGaDWfhg4EULPC7MN03ro Ik/FM+Sdv4KNyIztbDOqZg==; In-Reply-To: <87cyyawd1a.fsf@localhost> (message from Ihor Radchenko on Fri, 22 Sep 2023 13:30:41 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271107 Archived-At: > From: Ihor Radchenko > Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org > Date: Fri, 22 Sep 2023 13:30:41 +0000 > > Eli Zaretskii writes: > > >> Will it be acceptable to implement the cache using variable watchers? > > > > I don't like us using variable watchers for such stuff. > > > > Why cannot we just cache the correspondence between files and buffers > > in some hash-table? > > Because `buffer-file-name' can be modified from Lisp (via > `set-visited-file-name' or directly). Same for `buffer-file-truename' > and `buffer-file-number'. You could update the cache in set-visited-file-name, and ignore direct changes. > Or should we just assume that these variables remain unchanged other > than by primitives? Programs that make these changes are asking for trouble, IMO. AFAICT, find-buffer-visiting will never find such buffers anyway.