From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67569: 29.1; ruby-mode syntax highlighting breaks with variable named "index" and "/" operator Date: Sat, 09 Dec 2023 19:47:58 +0200 Message-ID: <83plzfw9m9.fsf@gnu.org> References: <0ee4ce91-c344-4859-8b13-07de5876368d@gutov.dev> <83zfyjwiiy.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28888"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mjh@mjhoy.com, 67569@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 09 18:49:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rC1S1-0007Kg-Vv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Dec 2023 18:49:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rC1Ra-00047D-4f; Sat, 09 Dec 2023 12:48:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rC1RZ-000474-Gw for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 12:48:49 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rC1RZ-0001X7-8P for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 12:48:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rC1Rm-0001EE-H7 for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 12:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Dec 2023 17:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67569 X-GNU-PR-Package: emacs Original-Received: via spool by 67569-submit@debbugs.gnu.org id=B67569.17021441184587 (code B ref 67569); Sat, 09 Dec 2023 17:49:02 +0000 Original-Received: (at 67569) by debbugs.gnu.org; 9 Dec 2023 17:48:38 +0000 Original-Received: from localhost ([127.0.0.1]:48866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC1RN-0001Bs-MX for submit@debbugs.gnu.org; Sat, 09 Dec 2023 12:48:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC1RJ-0001Ap-5Z for 67569@debbugs.gnu.org; Sat, 09 Dec 2023 12:48:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rC1Qz-0001UI-Rx; Sat, 09 Dec 2023 12:48:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uj8oIY1Yq4HKO6s6XuF6nWoqjAezECDjIkg6m9tidUo=; b=lwjmHLNoSwP7 XDHlRmppPGtE4Ll8ECboGFQ2kdfyyKVysGK8Bqr8HKCJRt8tz+pSH2anvuBH7C+SKGZNFi63D8juE R5831gHOk9hVVRdK3nRBILAD2mbR9zrm7Ung4EH5AmkHqo1Wwe36SptBLCmLBe7U9+pAbBFbtmgVA 4dvULLRYQDzIRMKF1tGfMmM0svzAitj1zvlt7FmyApAWY5zoh3GSKvjtcP6/SYTIlNRu8L9jMohUa 3MEhFfYp3Mn783NiykDdhQLDikSwoQxv5GGyeRUfLV2w52plzxtw6ctYrIfzxvTC3hFN6HWFRUXUK 0faSzU5InL8yXZ8nWDYUbw==; In-Reply-To: (message from Dmitry Gutov on Sat, 9 Dec 2023 19:38:28 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275872 Archived-At: > Date: Sat, 9 Dec 2023 19:38:28 +0200 > Cc: mjh@mjhoy.com, 67569@debbugs.gnu.org > From: Dmitry Gutov > > >> Eli, should we put this in Emacs 29.2? It's not a regression (a fairly > >> old problem), but the fix looks simple enough. > > Yes, please. > > Very good, pushed to emacs-29. > > Here's a second patch on top which gets rid of the whitelist altogether > (the new heuristic seems to cover the cases better anyway), though I'm > on the fence whether this should go here or into master. > > It seems to work well with some testing, but it is more adventurous than > the previous one. Yes, I think we have enough adventures on emacs-29.