From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sun, 17 Dec 2023 13:06:04 +0200 Message-ID: <83plz5jdgj.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <87il52w744.fsf@localhost> <83fs06rz10.fsf@gnu.org> <87fs06w4ui.fsf@localhost> <83bkaurut9.fsf@gnu.org> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> <871qboprh3.fsf@localhost> <87y1dwobey.fsf@localhost> <878r5v20gu.fsf@localhost> <83bkapl5zh.fsf@gnu.org> <83zfy9jkoh.fsf@gnu.org> <878r5tglwp.fsf@localhost> <83ttohjet0.fsf@gnu.org> <83sf41jed7.fsf@gnu.org> <87y1dtyu4y.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25739"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 17 12:07:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEozL-0006Qy-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Dec 2023 12:07:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEoz8-0006hB-VC; Sun, 17 Dec 2023 06:07:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEoz7-0006gy-LJ for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:07:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEoz7-0007aP-BM for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:07:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEoz8-000719-GF for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170281119426936 (code B ref 66117); Sun, 17 Dec 2023 11:07:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 17 Dec 2023 11:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:56636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEoyf-00070N-Vd for submit@debbugs.gnu.org; Sun, 17 Dec 2023 06:06:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEoyd-000706-Bh for 66117@debbugs.gnu.org; Sun, 17 Dec 2023 06:06:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEoyV-0007OZ-OH; Sun, 17 Dec 2023 06:06:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=A24hUUpDZhpZMT7PyU82G5fcqhFzmGUq/x7/Ego90qo=; b=mTifiKclmSyO h2ng32jDwBhSw1ihENzzg0Dn37nvFuRPw/rdlMVl4jNaVD1EBbhD9ijQF/OjgVl75KE58qdH3R2Td PgGVj0dtRXHKwxuv7P4ldRSOTmJtNKxKhj7mD+DVG0whPupB+F6QyO81puPoB80ZqzrtGiOaNIUPK J19xlk9pO9kAp4Yvhc86cn3HpcaXDkwywIvtiJkZNBmZeGcT3dFmKImnKY1DXXFqwDHepEszq/KaI tAQ3Cz6MylBLCThISBWfKqYo9Q/e5nx9J5aVkxN/kW3WyTDprCOEncAFxfhtqoRvOaFe/LEHj4MMf T5XW58aWAJafgwN+OUPV4Q==; In-Reply-To: <87y1dtyu4y.fsf@localhost> (message from Ihor Radchenko on Sun, 17 Dec 2023 10:56:45 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276415 Archived-At: > From: Ihor Radchenko > Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, mattias.engdegard@gmail.com, > monnier@iro.umontreal.ca > Date: Sun, 17 Dec 2023 10:56:45 +0000 > > Eli Zaretskii writes: > > > Also, re this part of the patch: > > > >> + DEFVAR_LISP ("case-fold-search", Vcase_fold_search, > >> + doc: /* Non-nil if searches and matches should ignore case. */); > >> + Vcase_fold_search = Qt; > >> + DEFSYM (Qcase_fold_search, "case-fold-search"); > >> + Fmake_variable_buffer_local (Qcase_fold_search); > > > > Which value does this set to t -- the global default? Isn't that > > different from what we had before? > > AFAIU, not different. Previously, we had > > > @@ -4785,7 +4779,6 @@ init_buffer_once (void) > > bset_tab_line_format (&buffer_defaults, Qnil); > > bset_abbrev_mode (&buffer_defaults, Qnil); > > bset_overwrite_mode (&buffer_defaults, Qnil); > > - bset_case_fold_search (&buffer_defaults, Qt); > > So, the default value was Qt previously as well. buffer_defaults is not the default value, AFAIU. > The DEFVAR_LISP + V... + DEFSYM + Fmake_variable_buffer_local is taken > from other buffer-local variables. For example, I'm talking specifically about any changes from previous behavior visible from Lisp. I think we should test all of the following: default-value default-boundp setq-default default-toplevel-value set-default-toplevel-value and make sure they all behave exactly the same, both in and out of a let-binding.