From: Eli Zaretskii <eliz@gnu.org>
To: one.last.kiss@outlook.com
Cc: 67658-done@debbugs.gnu.org
Subject: bug#67658: filesets can’t open files from menu-bar when using ‘:tree’
Date: Sat, 23 Dec 2023 11:01:57 +0200 [thread overview]
Message-ID: <83plyxe1h6.fsf@gnu.org> (raw)
In-Reply-To: <83wmtemlfm.fsf@gnu.org> (message from Eli Zaretskii on Sat, 16 Dec 2023 13:33:17 +0200)
> Cc: 67658@debbugs.gnu.org
> Date: Sat, 16 Dec 2023 13:33:17 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: ". shynur" <one.last.kiss@outlook.com>
> > Date: Wed, 6 Dec 2023 11:17:41 +0000
> >
> > Reproduce:
> >
> > PS D:/Tmp> dir
> > test.txt test.org
> > PS D:/Tmp> runemacs.exe -Q
> >
> > (require 'filesets)
> > (push `("Teest"
> > . ((:tree ,default-directory ""))) filesets-data)
> > (filesets-init)
> >
> > M-x eval-buffer
> >
> > Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/
> >
> > Then emacs just gave me an error:
> > “filesets-files-under: Wrong type argument: stringp, nil”
> >
> > I expected it to open all the files under that directory.
> > Am I missing something?
>
> You are not missing anything, this has been broken since Emacs 28.1,
> where we installed a change which fixed "normal" invocation of
> filesets-open, but broke its invocations from the menu-bar menus. The
> breakage was due to omitting from the fix to bug#976 the cautious 'if'
> clause in the original author's code.
>
> This should be fixed now on the emacs-29 branch.
No further comments, so I presume the bug was fixed, and I'm closing
it.
prev parent reply other threads:[~2023-12-23 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 11:17 bug#67658: filesets can’t open files from menu-bar when using ‘:tree’ . shynur
2023-12-16 11:33 ` Eli Zaretskii
2023-12-23 9:01 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83plyxe1h6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67658-done@debbugs.gnu.org \
--cc=one.last.kiss@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.