From: Eli Zaretskii <eliz@gnu.org>
To: Eshel Yaron <me@eshelyaron.com>
Cc: jm@pub.pink, 68213@debbugs.gnu.org
Subject: bug#68213: 30.0.50; completion-preview-tests failure in --without-x build
Date: Wed, 03 Jan 2024 19:27:44 +0200 [thread overview]
Message-ID: <83plyixr73.fsf@gnu.org> (raw)
In-Reply-To: <m1edeyvq62.fsf@dazzs-mbp.home> (message from Eshel Yaron on Wed, 03 Jan 2024 08:20:37 +0100)
> From: Eshel Yaron <me@eshelyaron.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 68213@debbugs.gnu.org
> Date: Wed, 03 Jan 2024 08:20:37 +0100
>
> john muhl <jm@pub.pink> writes:
>
> > Eshel Yaron <me@eshelyaron.com> writes:
> >
> >> FWIW, I was going to suggest the attached patch, following how
> >> flymake.el handles this. But if the current solution works, that seems
> >> just as good.
> >>
> > lisp/completion-preview-tests.el:23:2: Error: Duplicate
> > definition for key: "<mouse-5>" (keymap (mouse-5 .
> > completion-preview-prev-candidate) (down-mouse-2 .
> > completion-at-point) (C-down-mouse-1 . completion-at-point)
> > (down-mouse-1 . completion-preview-insert))
>
> Ah I can see that, thanks. IMO `defvar-keymap` is too strict in this
> case: the "duplicate" definition is not erroneous, it just happens to be
> redundant with some values of the `mwheel` variables. There's been some
> discussion around that in bug#56873, FWIW. So ISTM that the best way
> forward would be to make `defvar-keymap` more lax, perhaps optionally
> with a `:lax` keyword argument or some such. Any other ideas?
Please tell more, as I don't think I follow. Specifically:
. does the problem happen only in a --without-x build?
. what "duplicate" definitions do we have there and why?
Thanks.
next prev parent reply other threads:[~2024-01-03 17:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 16:42 bug#68213: 30.0.50; completion-preview-tests failure in --without-x build john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 17:11 ` Eli Zaretskii
2024-01-02 17:20 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 17:42 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-03 7:20 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-03 17:27 ` Eli Zaretskii [this message]
2024-01-03 18:45 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-03 19:18 ` Eli Zaretskii
2024-01-05 7:17 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-05 11:54 ` Eli Zaretskii
2024-01-07 17:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-07 17:19 ` Eli Zaretskii
2024-01-07 16:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 1:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 3:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 6:16 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 12:48 ` Eli Zaretskii
2024-01-08 14:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 17:12 ` Eli Zaretskii
2024-01-09 1:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 15:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 1:39 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 4:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 6:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 14:44 ` Drew Adams
2024-01-02 17:48 ` Eli Zaretskii
2024-01-07 16:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 17:48 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 19:15 ` Eli Zaretskii
2024-01-02 22:49 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-06 9:42 ` Eli Zaretskii
2024-01-07 17:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-07 17:09 ` Eli Zaretskii
2024-01-07 17:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 0:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 6:55 ` Eli Zaretskii
2024-01-13 7:17 ` Stefan Kangas
2024-01-20 9:15 ` Eli Zaretskii
2024-01-20 20:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83plyixr73.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68213@debbugs.gnu.org \
--cc=jm@pub.pink \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.