From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 37889523278: Add new `swap` macro and use it Date: Sat, 06 Jan 2024 17:34:14 +0200 Message-ID: <83plyescg9.fsf@gnu.org> References: <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org> <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org> <87plye9ahs.fsf@yahoo.com> <83o7dyua0d.fsf@gnu.org> <87le9297ei.fsf@yahoo.com> <87cyue92fx.fsf@yahoo.com> <877ckm8uzz.fsf@yahoo.com> <83v886sgtl.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12419"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 06 16:35:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rM8hh-00033q-1C for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jan 2024 16:35:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rM8gv-0007ra-IJ; Sat, 06 Jan 2024 10:34:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM8gp-0007rH-On for emacs-devel@gnu.org; Sat, 06 Jan 2024 10:34:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM8gp-000354-Fj; Sat, 06 Jan 2024 10:34:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xRgOW9ItqxZoZUwSpR0odpOU0YMAmVUz3yRTeYN/F9A=; b=ZtsSldjch/GF L9CrTg/5TTu3wtc7cHEVDbgJYE9nz0YUXSnxBlvoCG2mMyBIema7jsmqZakIoHxKdY4tAfmXlEoGp LJ/EUyyo3XQa9h5ZM7nTbm5gFE2Ha3kS33OSKQ2HGKuDKffP3xTd90o23Ff3lPybwLvG0R/yERM3b 2jsnb3/RfeSSk4YsK/nM/wjSJ1ncTSCxdeaK+ql9AcM+ylZKZQy7DkeF2sv0bTapCH7UIDVrsTohB CP1ArwMUjBO9ighQH2rD95zn4eKKfc2Om0QSB/G2QylooPYieV7+5OlNRQMNs74TPM+VAuI6jvLC/ DjKadOoJGCm/Zi2eV0IEmQ==; In-Reply-To: (message from Po Lu on Sat, 06 Jan 2024 22:41:40 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314636 Archived-At: > From: Po Lu > Cc: stefankangas@gmail.com, emacs-devel@gnu.org > Date: Sat, 06 Jan 2024 22:41:40 +0800 > > Eli Zaretskii writes: > > > Please in the future only revert commits by others without discussion > > if they either completely break a build or are obviously wrong. > > Everything else should be discussed first. > > There's no need to mention "in the future", because I have never done so > in the past :-) I can only try to affect the future, thus "in the future". > > Did Stefan's change break some build? If so, which build became > > broken and why? > > All builds using C compilers that don't support typeof, which is an > extension provided by GCC. In my case, the compiler was Sun C 5.12, > where __typeof__ is available but typeof is not (by default). Then you could have easily fixed the change instead of reverting it, right? Why didn't you? My opinion still is that reverting without discussion should be reserved only to very extreme situations, where fixing the problem is not easy, and the damage from the problem is serious. I hope others will behave according to that.