From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66554: [PATCH] Add the public API of Compat to the core Date: Fri, 12 Jan 2024 09:32:17 +0200 Message-ID: <83ply7j9by.fsf@gnu.org> References: <87pm1ggrdx.fsf@posteo.net> <87bk9scucg.fsf@daniel-mendler.de> <87y1cwpanh.fsf@posteo.net> <877ckgpa45.fsf@daniel-mendler.de> <87mstbpyd7.fsf@posteo.net> <87h6jjah1g.fsf@daniel-mendler.de> <87edenptba.fsf@posteo.net> <875xzzpqiu.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10380"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, stefankangas@gmail.com, monnier@iro.umontreal.ca, 66554@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 12 08:33:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOC2d-0002Sh-JH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jan 2024 08:33:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOC2Q-0004ve-FJ; Fri, 12 Jan 2024 02:33:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOC2M-0004sq-8J for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 02:33:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOC2K-0002m6-K5 for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 02:33:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOC2I-0004CZ-DO for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 02:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jan 2024 07:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66554-submit@debbugs.gnu.org id=B66554.170504476716124 (code B ref 66554); Fri, 12 Jan 2024 07:33:02 +0000 Original-Received: (at 66554) by debbugs.gnu.org; 12 Jan 2024 07:32:47 +0000 Original-Received: from localhost ([127.0.0.1]:34757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOC23-0004Bz-5l for submit@debbugs.gnu.org; Fri, 12 Jan 2024 02:32:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOC1z-0004Bk-3v for 66554@debbugs.gnu.org; Fri, 12 Jan 2024 02:32:45 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOC1u-0002Xa-Dj; Fri, 12 Jan 2024 02:32:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mTwV4fjS73eod8m85uDwO8VA6D+ab82iFxe+ujzeHuQ=; b=ryv5db9mGygp A18EB7VxY3RS7TIFECY8BdyVv/qQUd8m20YqfSfFCT9qVyZCZ10E6GoDC/8TnE55XP5sIp22PSSxj q5zY0gac2dKae11kEY2p+nlVdXrbbfQ8rk8enkyz5n7lq0Q966of1bIiPFNGEgKEf1V9K3aPJsWU6 0v4lovy/BeVxS0o60b/z5CIpq3MOGdNjDbBDz5XgfaC1UGy4acitxS5MVQC26Lw0eU21cj2tf2bTZ XlS00APRXGgAZSi7pdPKZoSS9/DVy+z/06iaOP/pTioTiC61fr/XaJvJOQi5A5iRL0gF/6n/ZdKbb a6rbf1OvL0C4+q/liOc1dQ==; In-Reply-To: <875xzzpqiu.fsf@posteo.net> (message from Philip Kaludercic on Thu, 11 Jan 2024 20:24:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277995 Archived-At: > From: Philip Kaludercic > Cc: Daniel Mendler , 66554@debbugs.gnu.org, > eliz@gnu.org, Stefan Kangas > Date: Thu, 11 Jan 2024 20:24:25 +0000 > > > The addition cab done procedurally, as in > > > > ;;;;####autoload (push (list 'compat emacs-major-version > > emacs-minor-version) package--builtin-versions) > > If this work, I like this idea a lot! I'll test it out to see if this > could simplify things. I'm not sure I understand the effects of the above -- can you explain? In general, if something needs to be done when the Emacs version is bumped, that action should be described in make-tarball.txt. It is a nuisance to follow the procedure there, only to be reminded of something else via a warning emitted by the build (and that is even before we consider the possibility that someone launches a build and goes for a coffee, while the warnings scroll on the screen with no one to see them). Likewise, if a file is modified by whatever commands we invoke to bump an Emacs version, that file should be mentioned in make-tarball.txt, because the person who performs that procedure will then need to commit the changes with a suitable log message, like we do today with configure.ac and the rest.