From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Next pretest Date: Fri, 29 Jan 2010 14:14:08 +0200 Message-ID: <83ockdrtv3.fsf@gnu.org> References: <87fx5vef1j.fsf@stupidchicken.com> <87sk9sga2k.fsf@stupidchicken.com> <83aaw068mj.fsf@gnu.org> <4B5F9ECB.1010601@gnu.org> <87aavz63x2.fsf@wanchan.jasonrumney.net> <87636n5xom.fsf@wanchan.jasonrumney.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1264767276 1673 80.91.229.12 (29 Jan 2010 12:14:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jan 2010 12:14:36 +0000 (UTC) Cc: lekktu@gmail.com, emacs-devel@gnu.org To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 29 13:14:33 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Napk8-0008Ta-F6 for ged-emacs-devel@m.gmane.org; Fri, 29 Jan 2010 13:14:32 +0100 Original-Received: from localhost ([127.0.0.1]:45255 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Napk7-0002At-KE for ged-emacs-devel@m.gmane.org; Fri, 29 Jan 2010 07:14:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Napk1-0002Am-Rw for emacs-devel@gnu.org; Fri, 29 Jan 2010 07:14:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Napjv-00027I-5Q for emacs-devel@gnu.org; Fri, 29 Jan 2010 07:14:25 -0500 Original-Received: from [199.232.76.173] (port=58227 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Napju-000271-Vk for emacs-devel@gnu.org; Fri, 29 Jan 2010 07:14:19 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:48061) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Napjs-00058n-5d; Fri, 29 Jan 2010 07:14:16 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0KX000J00CGM9Q00@a-mtaout23.012.net.il>; Fri, 29 Jan 2010 14:14:07 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.180.161]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX000IHTCNJK740@a-mtaout23.012.net.il>; Fri, 29 Jan 2010 14:14:07 +0200 (IST) In-reply-to: <87636n5xom.fsf@wanchan.jasonrumney.net> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120646 Archived-At: > From: Jason Rumney > Date: Thu, 28 Jan 2010 00:18:01 +0800 > Cc: emacs-devel@gnu.org >=20 > Juanma Barranquero writes: >=20 > > (I've changed three trivial typos emacs_ev. to emacs_ev->) >=20 > Thanks, I don't have a W32 installation here to try it on. > > In key_event, control is going through this branch > > > > else if (event->uChar.AsciiChar < 128) >=20 > try changing that to: >=20 > else if (event->uChar.AsciiChar > 0 && event->uChar.AsciiChar = < 128) >=20 > That should catch the following: >=20 > > uChar =3D { > > UnicodeChar =3D 164 L'=C2=A4\000', > > AsciiChar =3D -92 '=C2=A4' > > }, The "event->uChar.AsciiChar < 128" part in the above condition causes compiler warnings: w32inevt.c: In function `key_event': w32inevt.c:473: warning: comparison is always true due to limited r= ange of data type I think we can remove the second part, because AsciiChar is declared as CHAR, which is a `signed char' type, so it is always less than 128. Jason, do you agree? Juanma, can you check that removing that does not cause trouble in your use-case?