From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9010: sigprocmask -> pthread_sigmask for Emacs Date: Fri, 08 Jul 2011 13:16:27 +0300 Message-ID: <83oc15nklg.fsf@gnu.org> References: <4E14A53C.4060709@cs.ucla.edu> <83pqllnsv7.fsf@gnu.org> <4E16D4DF.5060307@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1310125856 22058 80.91.229.12 (8 Jul 2011 11:50:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 8 Jul 2011 11:50:56 +0000 (UTC) Cc: 9010@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 08 13:50:51 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qf9a4-00013q-Rg for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jul 2011 13:50:49 +0200 Original-Received: from localhost ([::1]:51827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qf9a4-0003FY-0V for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jul 2011 07:50:48 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qf89I-0004ZE-8z for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2011 06:19:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qf89G-00014P-Pr for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2011 06:19:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qf89G-00014J-An for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2011 06:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qf89F-0001S2-Q9; Fri, 08 Jul 2011 06:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jul 2011 10:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9010 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9010-submit@debbugs.gnu.org id=B9010.13101203165537 (code B ref 9010); Fri, 08 Jul 2011 10:19:01 +0000 Original-Received: (at 9010) by debbugs.gnu.org; 8 Jul 2011 10:18:36 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qf88p-0001RF-Hz for submit@debbugs.gnu.org; Fri, 08 Jul 2011 06:18:35 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qf88n-0001R2-2K for 9010@debbugs.gnu.org; Fri, 08 Jul 2011 06:18:34 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LO000C00F4PJG00@a-mtaout23.012.net.il> for 9010@debbugs.gnu.org; Fri, 08 Jul 2011 13:18:26 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.156.102]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LO000CGPFAPHJ70@a-mtaout23.012.net.il>; Fri, 08 Jul 2011 13:18:26 +0300 (IDT) In-reply-to: <4E16D4DF.5060307@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 08 Jul 2011 06:19:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:48243 Archived-At: > Date: Fri, 08 Jul 2011 02:58:55 -0700 > From: Paul Eggert > CC: 9010@debbugs.gnu.org > > On 07/08/11 00:17, Eli Zaretskii wrote: > > After your patch, will there be any code in Emacs that still uses > > sigprocmask? If not, we could just rename the w32.c sigprocmask stub > > to pthread_sigmask. If sigprocmask will still be used, then your > > suggestion for pthread_sigmask to call sigprocmask is TRT. > > There will still be some code in lib-src/emacsclient.c that uses sigprocmask, > because emacsclient is single-threaded and does not need pthread_sigmask. > pthread_sigmask sometimes needs extra libraries, such as -lpthread; > these libraries are ordinarily linked into Emacs anyway, so it's no > big deal for Emacs to call pthread_sigmask, but I'd rather not have > single-threaded apps link to -lpthread if they don't need it. > > Does emacsclient run on w32 and/or msdos? emacsclient works on w32, but it doesn't use the part that calls sigprocmask (NO_SOCKETS_IN_FILE_SYSTEM is defined on w32). So this is not an issue for w32. The MSDOS port doesn't support emacsclient at all. IIUC, using sigprocmask in Emacs proper will never be TRT. If so, we can simply rename the sigprocmask stub in w32 to be a pthread_sigmask stub.