--reverse-video and --no-window-system

--reverse-video and --no-window-system

[Glenn Morris]

--reverse-video has not worked with --no-window-system since Emacs 23.1
(bug#4238, etc). Does anyone know how to fix this?

Re: --reverse-video and --no-window-system

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Sat, 16 Jul 2011 14:27:53 -0400
> 
> 
> --reverse-video has not worked with --no-window-system since Emacs 23.1
> (bug#4238, etc). Does anyone know how to fix this?

Did anyone try?

Re: --reverse-video and --no-window-system

[Glenn Morris]

Eli Zaretskii wrote:

> Did anyone try?

Umm, yes, I did, but I could not fix it. Hence my question.

Re: --reverse-video and --no-window-system

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Sat, 16 Jul 2011 15:45:07 -0400
> 
> Eli Zaretskii wrote:
> 
> > Did anyone try?
> 
> Umm, yes, I did, but I could not fix it. Hence my question.

It's some snafu with the frame parameters, and the fact that when we
apply the reverse frame parameter, the colors are reversed, but the
frame parameter disappears from the alist.

I'll try to have a look during the pretest, if no one beats me to it.

Re: --reverse-video and --no-window-system

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

> --reverse-video has not worked with --no-window-system since Emacs 23.1
> (bug#4238, etc). Does anyone know how to fix this?

I've committed a fix.

Re: --reverse-video and --no-window-system

[Glenn Morris]

Chong Yidong wrote:

> Glenn Morris <rgm@gnu.org> writes:
>
>> --reverse-video has not worked with --no-window-system since Emacs 23.1
>> (bug#4238, etc). Does anyone know how to fix this?
>
> I've committed a fix.

Thanks!

Re: --reverse-video and --no-window-system

[Andreas Röhler]

Am 22.07.2011 07:03, schrieb Chong Yidong:
> Glenn Morris<rgm@gnu.org>  writes:
>
>> --reverse-video has not worked with --no-window-system since Emacs 23.1
>> (bug#4238, etc). Does anyone know how to fix this?
>
> I've committed a fix.
>
>

Hi,

thanks a lot. BTW: will 23.3 branch get the fix too?
Being in favour of keeping at least one Emacs as stable as possible.


Andreas

Re: --reverse-video and --no-window-system

[Chong Yidong]

Andreas Röhler <andreas.roehler@online.de> writes:

> thanks a lot. BTW: will 23.3 branch get the fix too?
> Being in favour of keeping at least one Emacs as stable as possible.

I guess the fix should be pretty safe, so I've merged it into the
emacs-23 branch too.  Note, however, that there are currently no plans
for any 23.4 release from this branch.

Re: --reverse-video and --no-window-system

[Andreas Röhler]

Am 22.07.2011 17:26, schrieb Chong Yidong:
> Andreas Röhler<andreas.roehler@online.de>  writes:
>
>> thanks a lot. BTW: will 23.3 branch get the fix too?
>> Being in favour of keeping at least one Emacs as stable as possible.
>
> I guess the fix should be pretty safe, so I've merged it into the
> emacs-23 branch too.

Great, thanks.
  Note, however, that there are currently no plans
> for any 23.4 release from this branch.
>

Hm, my suggestion is do prepare some bug-fix release at a certain time.

AFAIU it will take several months at least until 24 branch might 
qualified stable with respect to professionel environments.

Still the whole 24 branch might turn out less suitable then the previous 
- a pure abstract reasoning but we may derive from other experiences.

Thanks again,

Andreas

Re: --reverse-video and --no-window-system

[Sven Joachim]

On 2011-07-22 17:26 +0200, Chong Yidong wrote:

> Andreas Röhler <andreas.roehler@online.de> writes:
>
>> thanks a lot. BTW: will 23.3 branch get the fix too?
>> Being in favour of keeping at least one Emacs as stable as possible.
>
> I guess the fix should be pretty safe, so I've merged it into the
> emacs-23 branch too.

It breaks builds configured "--without-x" there:

,----
| frame.o: In function `Fmodify_frame_parameters':
| /usr/local/src/emacs/emacs-23/src/frame.c:2611: undefined reference to `update_face_from_frame_parameter'
`----

Could you please have a look?  The trunk builds fine --without-x.

Cheers,
       Sven

Re: --reverse-video and --no-window-system

[Chong Yidong]

Sven Joachim <svenjoac@gmx.de> writes:

> It breaks builds configured "--without-x" there:
>
> ,----
> | frame.o: In function `Fmodify_frame_parameters':
> | /usr/local/src/emacs/emacs-23/src/frame.c:2611: undefined reference
> | to `update_face_from_frame_parameter'
> `----
>
> Could you please have a look?  The trunk builds fine --without-x.

Fixed now, thanks for the heads up.