From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: fabrice.popineau@supelec.fr, emacs-devel@gnu.org,
ajmr@ilovetortilladepatatas.com
Subject: Re: Windows 64 port
Date: Wed, 29 Feb 2012 20:04:24 +0200 [thread overview]
Message-ID: <83obshcy8n.fsf@gnu.org> (raw)
In-Reply-To: <4F4D507F.7030008@cs.ucla.edu>
> Date: Tue, 28 Feb 2012 14:09:03 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Eli Zaretskii <eliz@gnu.org>, AJMR <ajmr@ilovetortilladepatatas.com>,
> emacs-devel@gnu.org
>
> > In src/dispnew.c:6402, height and width should probably be unsigned. The
> > checking by
> > INT_ADD_RANGE_OVERFLOW results in a compiler warning about integral
> > constant overflow
> > because it tries to compute (INTMIN - 2) which obviously is out of range.
> > The value is not used in this case, but the compiler may emit the warning
> > anyway.
>
> We don't need to modify the mainline Emacs code in order to
> pacify third-party compilers that issue incorrect warnings.
What is incorrect about that warning? Did Fabrice describe the issue
incorrectly? If so, would you mind explaining where his reasoning
about the validity of INT_MIN - 2 was wrong?
> We can safely ignore these warnings and leave the code alone.
We don't need to, but we might consider that anyway. If some
compiler tells us something valuable about the code, we
need not ignore it just because it's "third-party". My experience is
similar to that of Fabrice: compiling a program with several different
compilers helps find more problematic, unclean, and unsafe code. I'm
quite sure I saw this advice in some textbooks.
next prev parent reply other threads:[~2012-02-29 18:04 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 20:18 Windows 64 port AJMR
2012-02-19 21:26 ` Eli Zaretskii
2012-02-19 22:05 ` Fabrice Popineau
2012-02-20 3:53 ` Eli Zaretskii
2012-02-20 17:48 ` Paul Eggert
2012-02-20 19:20 ` Fabrice Popineau
2012-02-20 20:43 ` Paul Eggert
2012-02-20 20:58 ` Eli Zaretskii
2012-02-20 23:11 ` Fabrice Popineau
2012-02-20 23:46 ` Paul Eggert
2012-02-21 13:22 ` Stefan Monnier
2012-02-21 18:26 ` Paul Eggert
2012-02-22 10:39 ` Richard Stallman
2012-02-22 16:27 ` Eli Zaretskii
2012-02-23 18:44 ` Richard Stallman
2012-02-23 19:16 ` Aurélien
2012-02-23 19:50 ` Lennart Borgman
2012-02-23 20:48 ` Fabrice Popineau
2012-02-24 5:52 ` Aurélien
2012-02-28 21:00 ` Fabrice Popineau
2012-02-28 22:09 ` Paul Eggert
2012-02-28 22:39 ` Fabrice Popineau
2012-02-29 18:08 ` Eli Zaretskii
2012-02-29 22:08 ` Paul Eggert
2012-02-29 18:04 ` Eli Zaretskii [this message]
2012-02-29 19:43 ` Paul Eggert
2012-02-29 21:24 ` Eli Zaretskii
2012-03-01 3:34 ` Paul Eggert
2012-03-01 4:03 ` Eli Zaretskii
2012-03-01 6:28 ` Paul Eggert
2012-03-01 7:04 ` Fabrice Popineau
2012-03-22 17:31 ` Fabrice Popineau
2012-03-23 18:26 ` Paul Eggert
2012-03-24 9:27 ` Fabrice Popineau
2012-03-22 17:39 ` Fabrice Popineau
2012-03-22 18:02 ` Andreas Schwab
2012-03-22 18:34 ` Fabrice Popineau
2012-03-22 22:46 ` Andreas Schwab
2012-03-22 23:06 ` Fabrice Popineau
2012-03-22 23:38 ` Andreas Schwab
2012-03-23 8:12 ` Eli Zaretskii
2012-03-23 9:45 ` Andreas Schwab
2012-03-23 10:27 ` Fabrice Popineau
2012-03-23 10:42 ` Andreas Schwab
2012-03-23 12:21 ` Eli Zaretskii
2012-03-23 10:11 ` Fabrice Popineau
2012-03-23 18:13 ` Paul Eggert
2012-02-20 20:47 ` Eli Zaretskii
2012-02-26 20:17 ` AJMR
2012-02-26 21:25 ` Eli Zaretskii
2012-02-27 17:37 ` AJMR
2012-02-28 21:32 ` Fabrice Popineau
2012-03-01 3:23 ` Paul Eggert
2012-03-01 7:24 ` Fabrice Popineau
2012-03-01 8:58 ` Paul Eggert
2012-03-01 17:45 ` Eli Zaretskii
2012-03-01 20:05 ` Fabrice Popineau
2012-03-02 9:22 ` Eli Zaretskii
2012-03-02 20:35 ` Paul Eggert
2012-03-02 21:32 ` Fabrice Popineau
2012-03-02 22:06 ` Eli Zaretskii
2012-03-03 5:42 ` Paul Eggert
2012-03-03 7:18 ` Eli Zaretskii
2012-03-04 21:48 ` Paul Eggert
2012-03-03 7:58 ` Eli Zaretskii
2012-03-10 13:43 ` Eli Zaretskii
2012-03-22 17:15 ` Fabrice Popineau
2012-03-22 17:22 ` Fabrice Popineau
2012-03-22 18:29 ` Fabrice Popineau
2012-03-22 20:53 ` Stefan Monnier
2012-03-27 12:47 ` Fabrice Popineau
2012-03-27 16:08 ` Paul Eggert
2012-02-20 9:41 ` Richard Stallman
2012-02-20 10:28 ` Dani Moncayo
2012-02-21 12:10 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83obshcy8n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=ajmr@ilovetortilladepatatas.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=fabrice.popineau@supelec.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.