all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: dmantipov@yandex.ru, emacs-devel@gnu.org
Subject: Re: Hit eassert introduced in r110971
Date: Sun, 07 Apr 2013 05:49:32 +0300	[thread overview]
Message-ID: <83obdrcawz.fsf@gnu.org> (raw)
In-Reply-To: <jwvk3of2nc1.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: dmantipov@yandex.ru,  emacs-devel@gnu.org
> Date: Sat, 06 Apr 2013 20:36:35 -0400
> 
> > And btw, why do we at all care here about the selected window?
> > AFAICS, none of the code involved ever changes that.
> 
> As the comment indicates, this code needs to temporarily change the
> selected frame, and hence the selected window.

But we will immediately change the frame back, and with it the
window.  So I still don't see the problem.

> AFAIK, if this assertion fails, it means we have a problem somewhere.
> Not necessarily in update_tool_bar, but somewhere.

update_tool_bar is in this case called repeatedly for every frame we
have.  For each frame, it needs to make that frame the selected frame,
in order to do its job.  It doesn't care about the selected window,
and neither does its caller (redisplay_internal), because this code is
supposed to loop over all the frames.

So why do you think we have a problem here?



  reply	other threads:[~2013-04-07  2:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-06 16:35 Hit eassert introduced in r110971 Dmitry Antipov
2013-04-06 18:37 ` Eli Zaretskii
2013-04-06 19:16   ` Eli Zaretskii
2013-04-07  0:36     ` Stefan Monnier
2013-04-07  2:49       ` Eli Zaretskii [this message]
2013-04-07 13:50         ` Stefan Monnier
2013-04-07 15:37           ` Eli Zaretskii
2013-04-07 17:54             ` Stefan Monnier
2013-04-08 15:02       ` Eli Zaretskii
2013-04-08 17:40         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83obdrcawz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.