all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 15312@debbugs.gnu.org, kjambunathan@gmail.com
Subject: bug#15312: Info (point-entered, point-left): Doc incomplete, hence incorrect
Date: Fri, 13 Sep 2013 22:26:07 +0300	[thread overview]
Message-ID: <83ob7wh6b4.fsf@gnu.org> (raw)
In-Reply-To: <jwv4n9oprnr.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: kjambunathan@gmail.com,  15312@debbugs.gnu.org
> Date: Fri, 13 Sep 2013 13:18:37 -0400
> 
> >> > Sorry, I'm still in the dark.  Does the code presented in
> >> > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15312#11 work correctly
> >> > and as expected, or does it not?
> >> AFAICT, yes, it works fine.
> > Then please explain why it makes sense to call or not call these hooks
> > depending on whether some other unrelated text property changed at
> > point.
> 
> Hmm... I missed that part.  So it's sensitive to the C-level division
> into "struct interval"?  That would be a bug, indeed.

The problem, as I see it, is here:

  /* We run point-left and point-entered hooks here, if the
     two intervals are not equivalent.  These hooks take
     (old_point, new_point) as arguments.  */
  if (NILP (Vinhibit_point_motion_hooks)
      && (! intervals_equal (from, to)
	  || ! intervals_equal (fromprev, toprev)))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The intervals_equal test causes the whole code below that to be
skipped if each one of the point-entered and point-left properties
don't change between position POS and POS+1, and no other properties
change between those two positions.  When some other property does
change between those two positions, the hooks are called if
point-entered is different from point-left.  (Personally, I think this
test is just an attempt to optimize costly text property comparisons
when they are not necessary.)

To get this right, we need to decide what is the correct behavior in
this case.  Do we want the hooks to be called for each point motion,
or do we want them to be called only at point-min and point-max?

The documentation is not 100% clear, but it seems to imply that the
hooks shall be called for each movement, because point-entered is
different from point-left.  FWIW, this behavior won't make sense to
me, because there's no reason for point-entered and point-left to be
identical in the general case: each one of them reacts to a different
event.  But that's me.

Depending on what we think should be the correct behavior, we may or
may not need to fix the documentation.





  reply	other threads:[~2013-09-13 19:26 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09 13:34 bug#15312: Info (point-entered, point-left): Doc incomplete, hence incorrect Jambunathan K
2013-09-09 16:37 ` Eli Zaretskii
2013-09-10  3:33   ` Jambunathan K
2013-09-10  3:40     ` Jambunathan K
2013-09-10 15:18     ` Eli Zaretskii
2013-09-11  9:55       ` Jambunathan K
2013-09-11 13:42         ` Eli Zaretskii
2013-09-13  5:22           ` Jambunathan K
2013-09-13  6:15             ` Jambunathan K
2013-09-13  8:02               ` Eli Zaretskii
2013-09-13 10:28                 ` Jambunathan K
2013-09-13 13:12               ` Stefan Monnier
2013-09-13 13:29                 ` Eli Zaretskii
2013-09-13 15:15                   ` Stefan Monnier
2013-09-13 15:59                     ` Eli Zaretskii
2013-09-13 16:28                       ` Stefan Monnier
2013-09-13 16:42                         ` Jambunathan K
2013-09-13 16:45                         ` Eli Zaretskii
2013-09-13 17:18                           ` Stefan Monnier
2013-09-13 19:26                             ` Eli Zaretskii [this message]
2013-09-13 20:32                               ` Stefan Monnier
2013-09-14  6:48                                 ` Eli Zaretskii
2013-09-16 16:15                                   ` Stefan Monnier
2013-09-16 17:10                                     ` Eli Zaretskii
2013-09-13 16:20                     ` Jambunathan K
2013-09-13 16:43                       ` Eli Zaretskii
2013-09-13 17:19                         ` Stefan Monnier
2013-09-13 19:27                           ` Eli Zaretskii
2013-09-13 20:35                             ` Stefan Monnier
2013-09-14  6:50                               ` Eli Zaretskii
2013-09-13  8:03             ` Eli Zaretskii
2013-09-14  6:35               ` Jambunathan K
2013-11-15  5:04 ` Jambunathan K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ob7wh6b4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=15312@debbugs.gnu.org \
    --cc=kjambunathan@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.