From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org
Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme
Date: Thu, 31 Jul 2014 13:52:40 +0300 [thread overview]
Message-ID: <83oaw5ssuf.fsf@gnu.org> (raw)
In-Reply-To: <53DA0307.6040004@gmx.at>
> Date: Thu, 31 Jul 2014 10:49:11 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: mvoteiza@udel.edu, 18136@debbugs.gnu.org
>
> But I don't really understand about `set-frame-height' and friends on a
> TTY and what they are supposed to do. Should these be allowed to change
> the frame size?
Yes.
> Now about the
>
> change_frame_size (XFRAME (selected_frame),
> FrameCols (t->display_info.tty),
> FrameRows (t->display_info.tty)
> - FRAME_MENU_BAR_LINES (f), 0, 0, 1, 0);
>
> call in init_display. What precisely is this supposed to accomplish?
Allocate the glyph matrices, at the very least, I guess.
> Back to init_display and the question I asked earlier: Why should the
> subsequent adjust_frame_size call do
>
> if ((FRAME_TERMCAP_P (f) && !pretend) || FRAME_MSDOS_P (f))
> FrameRows (FRAME_TTY (f)) = new_lines;
>
> here?
Maybe it shouldn't, when called from init_display. But we should at
least leave an eassert there, in case we overlook something.
In any case, this begs the question: why do you at all call
adjust_frame_size in this case, if the frame already has the required
size? I think the answer is that adjust_frame_size does something
else: it calls adjust_frame_glyphs. That call is required at
init_display time for obvious reasons, but it is inside
adjust_frame_size which is only called when the frame size changes,
which sounds like a contradiction in the design.
> Now please tell me one thing: Which calls of change_frame_size or
> adjust_frame_size _should_ set FrameRows or FrameCols
Any calls that actually change the frame size.
> and how can I distinguish them?
You already do, if I understand your description. You already avoid
calling adjust_frame_size unless the size really changes.
next prev parent reply other threads:[~2014-07-31 10:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 0:36 bug#18136: 24.4.50; crash in redisplay when calling load-theme Mark Oteiza
2014-07-29 9:05 ` Eli Zaretskii
2014-07-29 10:44 ` martin rudalics
2014-07-29 12:12 ` Eli Zaretskii
2014-07-29 14:02 ` martin rudalics
2014-07-29 14:47 ` Eli Zaretskii
2014-07-29 15:41 ` martin rudalics
2014-07-29 16:31 ` Eli Zaretskii
2014-07-29 18:23 ` martin rudalics
2014-07-29 18:29 ` Eli Zaretskii
2014-07-30 16:45 ` martin rudalics
2014-07-30 17:18 ` Eli Zaretskii
2014-07-30 17:36 ` martin rudalics
2014-07-30 17:52 ` Eli Zaretskii
2014-07-31 8:49 ` martin rudalics
2014-07-31 10:52 ` Eli Zaretskii [this message]
2014-07-31 16:53 ` martin rudalics
2014-07-31 17:55 ` Eli Zaretskii
2014-08-01 8:57 ` martin rudalics
2014-08-01 12:55 ` Eli Zaretskii
2014-08-04 17:23 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83oaw5ssuf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18136@debbugs.gnu.org \
--cc=mvoteiza@udel.edu \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.