all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: emacs-devel@gnu.org
Subject: Re: process_send_string blocks?
Date: Sat, 06 Sep 2014 16:28:05 +0300	[thread overview]
Message-ID: <83oausdgka.fsf@gnu.org> (raw)
In-Reply-To: <85ppf8evwu.fsf@stephe-leake.org>

> From: Stephen Leake <stephen_leake@stephe-leake.org>
> Date: Sat, 06 Sep 2014 08:11:13 -0500
> 
> >> On reading process.c, I believe this should not happen, if the OS supports
> >> EWOULDBLOCK. 
> >> 
> >> Is that true, even when there is only one call to process-send-string that
> >> sends the entire buffer?
> >
> > Not sure what are you asking here, since you say you've read the code
> > and saw the handling of EWOULDBLOCK.
> 
> Because it is often easy to misunderstand code that I am reading for the
> first time. For example, I completely missed the threading stuff you
> talk about below.

The threads I described are below the level you see in process.c, they
are Windows-specific implementations of 'read', 'write', and 'pselect'
semantics.  On the process.c level, the code handles EWOULDBLOCK on
write, by queuing the rest of the stuff and looping while reading
input.  This is independent of what the lower levels do.

> >> I'm running on Windows 7, using the Windows binary
> >> emacs-23.4-bin-i386.zip from the FSF FTP site.
> >> 
> >> Is EWOULDBLOCK supported on this system?
> >
> > Not on writes to pipes, AFAIK.
> 
> Ah, then that's the problem. Hmm, except below you seem to be saying
> maybe it's not?

I don't know.  It could be.  The implementation of Emacs subprocesses
on Windows is non-trivial, and I cannot claim I have a 100% clear
picture of everything that's going on there.  In addition, there are
other threads that could potentially be involved.

So it's possible that the deadlock is very simple, but there could be
surprises.  Only debugging will tell.

> I have a reliable reproducer, which I can easily simplify.

Please do simplify it and post it.  Having a way of debugging this by
several people will definitely make the process more efficient, and
probably produce a higher quality solution.

Btw, do you see the problem in "emacs -Q"?

Thanks.



  reply	other threads:[~2014-09-06 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-06  8:09 process_send_string blocks? Stephen Leake
2014-09-06  8:28 ` Jorgen Schaefer
2014-09-06  9:34 ` Eli Zaretskii
2014-09-06 13:11   ` Stephen Leake
2014-09-06 13:28     ` Eli Zaretskii [this message]
2014-09-07  8:21       ` Stephen Leake
2014-09-07 15:44         ` Eli Zaretskii
2014-09-07 20:32           ` Stephen Leake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83oausdgka.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stephen_leake@stephe-leake.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.