From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#96: lgrep/rgrep not asking to save buffers Date: Sun, 25 Jan 2015 19:58:04 +0200 Message-ID: <83oapmrbdf.fsf@gnu.org> References: <87a916c0v4.fsf@tethys.saintaardvarkthecarpeted.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1422208756 7945 80.91.229.3 (25 Jan 2015 17:59:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 25 Jan 2015 17:59:16 +0000 (UTC) Cc: tromey@redhat.com, 96@debbugs.gnu.org To: Hugh Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 25 18:59:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YFRSp-0007c2-5v for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jan 2015 18:59:11 +0100 Original-Received: from localhost ([::1]:38490 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFRSo-0003K9-Fr for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jan 2015 12:59:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFRSl-0003K4-4c for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 12:59:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFRSg-0008JI-66 for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 12:59:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFRSg-0008JE-2m for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 12:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YFRSf-0007Yk-M1 for bug-gnu-emacs@gnu.org; Sun, 25 Jan 2015 12:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jan 2015 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 96 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 96-submit@debbugs.gnu.org id=B96.142220870928967 (code B ref 96); Sun, 25 Jan 2015 17:59:01 +0000 Original-Received: (at 96) by debbugs.gnu.org; 25 Jan 2015 17:58:29 +0000 Original-Received: from localhost ([127.0.0.1]:56186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFRS8-0007X8-Qc for submit@debbugs.gnu.org; Sun, 25 Jan 2015 12:58:29 -0500 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:57307) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFRS6-0007Wh-Ch for 96@debbugs.gnu.org; Sun, 25 Jan 2015 12:58:27 -0500 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NIQ00E00USN3100@mtaout25.012.net.il> for 96@debbugs.gnu.org; Sun, 25 Jan 2015 19:53:35 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIQ00413V1BWFA0@mtaout25.012.net.il>; Sun, 25 Jan 2015 19:53:35 +0200 (IST) In-reply-to: <87a916c0v4.fsf@tethys.saintaardvarkthecarpeted.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98720 Archived-At: > From: Hugh Brown > Date: Sun, 25 Jan 2015 07:54:07 -0800 > Cc: 96@debbugs.gnu.org > > Hi there -- I'm submitting a patch for this bug. It applies cleanly > against the HEAD of the master branch right now > (f67446455fc0ec59f5c25c90a8783e571b60dc8f). Thanks. Please provide a log entry for this. > +(defcustom grep-ask-about-save t > + "Non-nil means \\[grep], \\[lgrep] and \\[rgrep] ask which buffers to save before running. > +Otherwise, it saves all modified buffers without asking." > + :type 'boolean > + :group 'grep) Is there a way to get back the current behavior, i.e. not save any buffers? In any case, this is a change in user-visible behavior, so I think it warrants a NEWS entry Also, this defcustom lacks a :version keyword. > +(defcustom grep-save-buffers-predicate nil > + "The second argument (PRED) passed to `save-some-buffers' before compiling. > +E.g., one can set this to > + (lambda () > + (string-prefix-p my-grep-root (file-truename (buffer-file-name)))) > +to limit saving to files located under `my-grep-root'. Did you consider letting grep-ask-about-save serve double duty, in that it could also be a predicate function? I'm not saying this would necessarily be better, I'm just asking why not.