From: Eli Zaretskii <eliz@gnu.org>
To: Hugh Brown <aardvark@saintaardvarkthecarpeted.com>
Cc: tromey@redhat.com, 96@debbugs.gnu.org
Subject: bug#96: lgrep/rgrep not asking to save buffers
Date: Sun, 25 Jan 2015 19:58:04 +0200 [thread overview]
Message-ID: <83oapmrbdf.fsf@gnu.org> (raw)
In-Reply-To: <87a916c0v4.fsf@tethys.saintaardvarkthecarpeted.com>
> From: Hugh Brown <aardvark@saintaardvarkthecarpeted.com>
> Date: Sun, 25 Jan 2015 07:54:07 -0800
> Cc: 96@debbugs.gnu.org
>
> Hi there -- I'm submitting a patch for this bug. It applies cleanly
> against the HEAD of the master branch right now
> (f67446455fc0ec59f5c25c90a8783e571b60dc8f).
Thanks. Please provide a log entry for this.
> +(defcustom grep-ask-about-save t
> + "Non-nil means \\[grep], \\[lgrep] and \\[rgrep] ask which buffers to save before running.
> +Otherwise, it saves all modified buffers without asking."
> + :type 'boolean
> + :group 'grep)
Is there a way to get back the current behavior, i.e. not save any
buffers?
In any case, this is a change in user-visible behavior, so I think it
warrants a NEWS entry
Also, this defcustom lacks a :version keyword.
> +(defcustom grep-save-buffers-predicate nil
> + "The second argument (PRED) passed to `save-some-buffers' before compiling.
> +E.g., one can set this to
> + (lambda ()
> + (string-prefix-p my-grep-root (file-truename (buffer-file-name))))
> +to limit saving to files located under `my-grep-root'.
Did you consider letting grep-ask-about-save serve double duty, in
that it could also be a predicate function? I'm not saying this would
necessarily be better, I'm just asking why not.
next prev parent reply other threads:[~2015-01-25 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 20:07 lgrep/rgrep not asking to save buffers Tom Tromey
2015-01-25 15:54 ` bug#96: " Hugh Brown
2015-01-25 17:58 ` Eli Zaretskii [this message]
2016-02-29 5:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83oapmrbdf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=96@debbugs.gnu.org \
--cc=aardvark@saintaardvarkthecarpeted.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.