From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Debugging emacs memory management Date: Tue, 06 Oct 2015 05:41:22 +0300 Message-ID: <83oagcyazx.fsf@gnu.org> References: <87zj8l3r32.fsf@secretsauce.net> <87vbbbxz2e.fsf@secretsauce.net> <55F998C8.4080203@cs.ucla.edu> <87vbb492ea.fsf@secretsauce.net> <83twqonub8.fsf@gnu.org> <87oagw885o.fsf@secretsauce.net> <837fnknlbm.fsf@gnu.org> <834mionkdg.fsf@gnu.org> <87fv1p232b.fsf@secretsauce.net> <83wpv1zr4q.fsf@gnu.org> <87egh9205z.fsf@secretsauce.net> <83r3l9zowx.fsf@gnu.org> <87d1wt1xe0.fsf@secretsauce.net> <87bncd1w88.fsf@secretsauce.net> <87a8rx1vmf.fsf@secretsauce.net> <83lhbhzj6b.fsf@gnu.org> <877fn118m5.fsf@secretsauce.net> <87a8rwaolf.fsf@secretsauce.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1444099311 30782 80.91.229.3 (6 Oct 2015 02:41:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Oct 2015 02:41:51 +0000 (UTC) Cc: schwab@suse.de, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Dima Kogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 06 04:41:41 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZjICB-000727-1u for ged-emacs-devel@m.gmane.org; Tue, 06 Oct 2015 04:41:39 +0200 Original-Received: from localhost ([::1]:48703 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjICA-00019B-Az for ged-emacs-devel@m.gmane.org; Mon, 05 Oct 2015 22:41:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjIBy-000191-7d for emacs-devel@gnu.org; Mon, 05 Oct 2015 22:41:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjIBv-00033L-2b for emacs-devel@gnu.org; Mon, 05 Oct 2015 22:41:26 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:42058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjIBu-00032v-RJ for emacs-devel@gnu.org; Mon, 05 Oct 2015 22:41:23 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NVS00O001LDG300@mtaout25.012.net.il> for emacs-devel@gnu.org; Tue, 06 Oct 2015 05:38:42 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVS00I2S20IRG70@mtaout25.012.net.il>; Tue, 06 Oct 2015 05:38:42 +0300 (IDT) In-reply-to: <87a8rwaolf.fsf@secretsauce.net> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190991 Archived-At: > From: Dima Kogan > Cc: schwab@suse.de, eggert@cs.ucla.edu, emacs-devel@gnu.org > Date: Mon, 05 Oct 2015 16:21:32 -0700 > > Dima Kogan writes: > > > Here's the updated patch: > > > > diff --git a/src/font.c b/src/font.c > > index 8e06532..dd574ca 100644 > > --- a/src/font.c > > +++ b/src/font.c > > @@ -3981,7 +3981,12 @@ copy_font_spec (Lisp_Object font) > > pcdr = spec->props + FONT_EXTRA_INDEX; > > for (tail = AREF (font, FONT_EXTRA_INDEX); CONSP (tail); tail = XCDR (tail)) > > if (!EQ (XCAR (XCAR (tail)), QCfont_entity)) > > - *pcdr = Fcons (XCAR (tail), Qnil), pcdr = xcdr_addr (*pcdr); > > + { > > + *pcdr = Fcons (Fcons( XCAR (XCAR (tail)), > > + XCDR (XCAR (tail))), > > + Qnil); > > + pcdr = xcdr_addr (*pcdr); > > + } > > > > XSETFONT (new_spec, spec); > > return new_spec; > > After a bit more testing, I'm happy with this patch. Thoughts about > merging it? Let's wait for a few days, and push if not objections. > Should I open a bug tracker entry to keep track of it? Might be a good idea, yes. Please mention this thread there, if you do. Thanks.