From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Master is broken Date: Sat, 10 Oct 2015 13:54:48 +0300 Message-ID: <83oag7ro1z.fsf@gnu.org> References: <838u7bt8id.fsf@gnu.org> <86zizr57g7.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1444474514 27382 80.91.229.3 (10 Oct 2015 10:55:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 10 Oct 2015 10:55:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 10 12:55:05 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zkrnp-0006Jy-Bz for ged-emacs-devel@m.gmane.org; Sat, 10 Oct 2015 12:55:01 +0200 Original-Received: from localhost ([::1]:44427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zkrno-0007vX-QY for ged-emacs-devel@m.gmane.org; Sat, 10 Oct 2015 06:55:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zkrnd-0007vQ-45 for emacs-devel@gnu.org; Sat, 10 Oct 2015 06:54:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkrnY-0007iZ-4N for emacs-devel@gnu.org; Sat, 10 Oct 2015 06:54:49 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:33577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkrnX-0007gt-TL for emacs-devel@gnu.org; Sat, 10 Oct 2015 06:54:44 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NW000D0038RGB00@mtaout28.012.net.il> for emacs-devel@gnu.org; Sat, 10 Oct 2015 13:54:09 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NW000ESS3M95N00@mtaout28.012.net.il>; Sat, 10 Oct 2015 13:54:09 +0300 (IDT) In-reply-to: <86zizr57g7.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191124 Archived-At: > From: Andy Moreton > Date: Sat, 10 Oct 2015 11:44:24 +0100 > > > I'm not really sure what's going on here, all this INLINE stuff is too > > complicated. These 2 inline functions are clearly visible in the > > preprocessed source, and still the linker barfs. The only way I could > > make it link successfully was by including puresize.h in emacs.c as > > well, but then temacs crashed during loadup. > > The comments in the definition of INLINE explain how this is supposed to > work. They do? Then I'm probably missing something, because I cannot find where it says that emacs.c should include any header that uses INLINE. (Do you mean the comments in conf_post.h?) I arrived at that by using "nm -A" on the various *.o files that use INLINE, looking for *.o files that define those symbols. > I see the same errors with mingw64: the patch below fixed > bootstrap for me. I installed the change in emacs.c recently. The change in puresize.h is not needed to fix the problem, neither on GNU/Linux nor in the mingw32 build. Are you saying that without the changes in puresize.h you cannot compile/link the current master? If so, please show the error messages. Thanks.