all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Master is broken
Date: Sat, 10 Oct 2015 13:54:48 +0300	[thread overview]
Message-ID: <83oag7ro1z.fsf@gnu.org> (raw)
In-Reply-To: <86zizr57g7.fsf@gmail.com>

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sat, 10 Oct 2015 11:44:24 +0100
> 
> > I'm not really sure what's going on here, all this INLINE stuff is too
> > complicated.  These 2 inline functions are clearly visible in the
> > preprocessed source, and still the linker barfs.  The only way I could
> > make it link successfully was by including puresize.h in emacs.c as
> > well, but then temacs crashed during loadup.
> 
> The comments in the definition of INLINE explain how this is supposed to
> work.

They do?  Then I'm probably missing something, because I cannot find
where it says that emacs.c should include any header that uses INLINE.
(Do you mean the comments in conf_post.h?)  I arrived at that by using
"nm -A" on the various *.o files that use INLINE, looking for *.o
files that define those symbols.

> I see the same errors with mingw64: the patch below fixed
> bootstrap for me.

I installed the change in emacs.c recently.  The change in puresize.h
is not needed to fix the problem, neither on GNU/Linux nor in the
mingw32 build.  Are you saying that without the changes in puresize.h
you cannot compile/link the current master?  If so, please show the
error messages.

Thanks.



  reply	other threads:[~2015-10-10 10:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10  8:47 Master is broken Eli Zaretskii
2015-10-10 10:44 ` Andy Moreton
2015-10-10 10:54   ` Eli Zaretskii [this message]
2015-10-10 11:27     ` Andy Moreton
2015-10-10 10:46 ` Eli Zaretskii
2015-10-10 15:59   ` Andreas Schwab
2015-10-10 16:19     ` Eli Zaretskii
2015-10-10 16:46   ` Paul Eggert
2015-10-10 17:06     ` Eli Zaretskii
2015-10-10 17:12       ` Eli Zaretskii
2015-10-10 19:01         ` Paul Eggert
2015-10-10 19:05           ` Eli Zaretskii
2015-10-10 19:31             ` Paul Eggert
2015-10-11  0:13           ` Juanma Barranquero
2015-10-11  0:32             ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83oag7ro1z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.