From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Sat, 07 Nov 2015 15:38:31 +0200 Message-ID: <83oaf6oroo.fsf@gnu.org> References: <20151102123512.GB11804@acm.fritz.box> <20151102154445.GD11804@acm.fritz.box> <87h9l46l7o.fsf@mail.linkov.net> <20151103123116.GD2258@acm.fritz.box> <83a8qvw0aq.fsf@gnu.org> <20151103221131.GG2258@acm.fritz.box> <87mvuur4kn.fsf@mail.linkov.net> <20151107125931.GA1770@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1446903622 24665 80.91.229.3 (7 Nov 2015 13:40:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Nov 2015 13:40:22 +0000 (UTC) Cc: 17453@debbugs.gnu.org, bruce.connor.am@gmail.com, juri@linkov.net To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 07 14:40:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zv3j1-000437-F3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Nov 2015 14:40:11 +0100 Original-Received: from localhost ([::1]:43880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv3j0-00079A-Ds for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Nov 2015 08:40:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv3iv-00073o-SF for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 08:40:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zv3is-0006Da-II for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 08:40:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv3is-0006DW-Fd for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 08:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zv3ir-0001im-Sd for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 08:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Nov 2015 13:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17453-submit@debbugs.gnu.org id=B17453.14469035416527 (code B ref 17453); Sat, 07 Nov 2015 13:40:01 +0000 Original-Received: (at 17453) by debbugs.gnu.org; 7 Nov 2015 13:39:01 +0000 Original-Received: from localhost ([127.0.0.1]:56571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zv3hs-0001h6-TD for submit@debbugs.gnu.org; Sat, 07 Nov 2015 08:39:01 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:63817) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zv3hX-0001ga-Hy for 17453@debbugs.gnu.org; Sat, 07 Nov 2015 08:38:59 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NXG00A005UD8200@a-mtaout20.012.net.il> for 17453@debbugs.gnu.org; Sat, 07 Nov 2015 15:38:37 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NXG00A4P5WD2W40@a-mtaout20.012.net.il>; Sat, 07 Nov 2015 15:38:37 +0200 (IST) In-reply-to: <20151107125931.GA1770@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108521 Archived-At: > Date: Sat, 7 Nov 2015 12:59:31 +0000 > Cc: Artur Malabarba , Eli Zaretskii , > 17453@debbugs.gnu.org > From: Alan Mackenzie > > Proposed solutions: > 1. Call follow-post-command-hook from isearch-update before calling > isearch-lazy-highlight-new-loop (as described above). > 2. Call the proposed function `redisplay-would-scroll-window' instead of > the `sit-for'. > 3. Make isearch-lazy-highlight-new-loop always set the idle timer, and > test for the need for a new loop instead in the function it triggers. > Remove the `sit-for'. > > I now think solution 2. is not sensible or realistic. Redisplay is just > too complicated to second-guess. > > Solution 1. has the disadvantage that follow-post-command-hook would be > called twice for every command in Isearch. It is not fast. > > Solution 3. similarly might have the problem that if > lazy-highlight-initial-delay is set to zero, redisplay might not have > done its work when isearch-lazy-highlight-update runs. (I haven't tried > it out, yet). > > Personally, I am in favour of solution 3, but I'm willing to be persuaded > into solution 1. But I'd like us to come to a decision quickly. How about using 1), but also adding some indication that could prevent the post-command-hook from being called twice?