From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org, kuleshovmail@gmail.com
Subject: Re: [PATCH] Fix compilation erorr when --enable-gcc-warnings passed
Date: Sat, 23 Jan 2016 11:23:11 +0200 [thread overview]
Message-ID: <83oacc645c.fsf@gnu.org> (raw)
In-Reply-To: <56A342F8.1080303@cs.ucla.edu> (message from Paul Eggert on Sat, 23 Jan 2016 01:08:08 -0800)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sat, 23 Jan 2016 01:08:08 -0800
> Cc: emacs-devel@gnu.org
>
> I installed a patch into emacs-25 to replace the compile-time warning with a
> run-time crash, if you configure --with-cairo --enable-checking and visit a .png
> file.
If we know in advance that some scenario doesn't work, then eassert is
not TRT. We should signal an error instead. eassert is for things
that "cannot happen", i.e. they are there to help us discover the
(unknown) scenarios where our assumptions are false. In this case,
the scenario is already known, and moreover it is very simple to
trigger, so aborting is not the best strategy.
next prev parent reply other threads:[~2016-01-23 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 10:54 [PATCH] Fix compilation erorr when --enable-gcc-warnings passed Alexander Kuleshov
2016-01-23 0:06 ` Paul Eggert
2016-01-23 6:28 ` Alexander Kuleshov
2016-01-23 9:08 ` Paul Eggert
2016-01-23 9:23 ` Eli Zaretskii [this message]
2016-01-23 9:41 ` Paul Eggert
2016-01-23 11:57 ` Alexander Kuleshov
2016-01-23 12:04 ` Alexander Kuleshov
2016-01-23 12:37 ` Alexander Kuleshov
2016-01-24 0:49 ` Paul Eggert
2016-01-24 7:34 ` Alexander Kuleshov
2016-01-24 8:49 ` bug#22442: " Paul Eggert
2016-01-23 9:12 ` bug#22442: 25.0.50; --with-cairo does not display PNG on GNU/Linux Paul Eggert
2016-01-23 9:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83oacc645c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=kuleshovmail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.