From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: emacs-devel@gnu.org
Subject: Re: About x_draw_xwidget_glyph_string
Date: Mon, 25 Jan 2016 17:46:00 +0200 [thread overview]
Message-ID: <83oac93bnr.fsf@gnu.org> (raw)
In-Reply-To: <wlvb6il8dn.wl%mituharu@math.s.chiba-u.ac.jp> (message from YAMAMOTO Mitsuharu on Mon, 25 Jan 2016 11:07:16 +0900)
> Date: Mon, 25 Jan 2016 11:07:16 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>
> 2. Comment on clipping.
>
> 578 /* Calculate clipping, which is used for all manner of onscreen
> 579 xwidget views. Each widget border can get clipped by other emacs
> 580 objects so there are four clipping variables. */
> 581 clip_right =
> 582 min (xww->width,
> 583 WINDOW_RIGHT_EDGE_X (s->w) - x -
> 584 WINDOW_RIGHT_SCROLL_BAR_AREA_WIDTH (s->w) -
> 585 WINDOW_RIGHT_FRINGE_WIDTH (s->w));
> 586 clip_left =
> 587 max (0,
> 588 WINDOW_LEFT_EDGE_X (s->w) - x +
> 589 WINDOW_LEFT_SCROLL_BAR_AREA_WIDTH (s->w) +
> 590 WINDOW_LEFT_FRINGE_WIDTH (s->w));
> 591
> 592 clip_bottom =
> 593 min (xww->height,
> 594 WINDOW_BOTTOM_EDGE_Y (s->w) - WINDOW_MODE_LINE_HEIGHT (s->w) - y);
> 595 clip_top = max (0, WINDOW_TOP_EDGE_Y (s->w) - y);
>
> I think the calculation of clipping should use the function window_box
> rather than manual calculation with various window macros. Otherwise,
> xwidget views will cover horizontal scroll bars, for example.
I agree.
Thanks.
next prev parent reply other threads:[~2016-01-25 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 2:07 About x_draw_xwidget_glyph_string YAMAMOTO Mitsuharu
2016-01-25 6:59 ` joakim
2016-01-25 15:46 ` Eli Zaretskii [this message]
2016-04-08 15:35 ` joakim
2016-04-09 7:38 ` Eli Zaretskii
2016-04-09 11:22 ` joakim
2016-04-09 12:06 ` Eli Zaretskii
2016-04-10 8:29 ` YAMAMOTO Mitsuharu
2016-04-11 0:04 ` YAMAMOTO Mitsuharu
2016-04-12 20:46 ` joakim
2016-04-12 21:13 ` joakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83oac93bnr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.