From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23203: 25.0.91; some loaddefs files have auto-save remnants after building (and install doesn't ignore them) Date: Mon, 04 Apr 2016 18:27:53 +0300 Message-ID: <83oa9po0li.fsf@gnu.org> References: <87twjjqidp.fsf@Rainer.invalid> <87shz35b8i.fsf@Rainer.invalid> <87lh4v0y1z.fsf@linux-m68k.org> <87egam6hif.fsf@Rainer.invalid> <3bf1141d622845eb4fe66b6dce573551.squirrel@cloud103.planethippo.com> <83fuv2plj5.fsf@gnu.org> <837fgepjm7.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459783767 13704 80.91.229.3 (4 Apr 2016 15:29:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2016 15:29:27 +0000 (UTC) Cc: 23203@debbugs.gnu.org, stromeko@nexgo.de To: "Phillip Lord" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 04 17:29:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1an6RD-0003ZM-K6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2016 17:29:11 +0200 Original-Received: from localhost ([::1]:59360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an6RC-0003O6-RU for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2016 11:29:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an6R8-0003NR-EY for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 11:29:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an6R4-0000Mj-6g for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 11:29:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an6R4-0000Mf-2w for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 11:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1an6R3-0004Fo-Uo for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 11:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2016 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23203 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23203-submit@debbugs.gnu.org id=B23203.145978371316318 (code B ref 23203); Mon, 04 Apr 2016 15:29:01 +0000 Original-Received: (at 23203) by debbugs.gnu.org; 4 Apr 2016 15:28:33 +0000 Original-Received: from localhost ([127.0.0.1]:51264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an6Qa-0004F8-V6 for submit@debbugs.gnu.org; Mon, 04 Apr 2016 11:28:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an6QZ-0004Ev-CA for 23203@debbugs.gnu.org; Mon, 04 Apr 2016 11:28:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an6QT-0000Js-8w for 23203@debbugs.gnu.org; Mon, 04 Apr 2016 11:28:26 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an6QN-0000JN-2D; Mon, 04 Apr 2016 11:28:19 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1an6QM-00060j-CD; Mon, 04 Apr 2016 11:28:18 -0400 In-reply-to: (phillip.lord@russet.org.uk) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:116024 Archived-At: > Date: Sun, 3 Apr 2016 21:11:34 +0100 > From: "Phillip Lord" > Cc: "Phillip Lord" , > 23203@debbugs.gnu.org, > stromeko@nexgo.de > > Actually, my first batch did not exempt autoload files. It only did that > when called using batch-update-autoloads: i.e. in batch, and in a function > which is commented (but not documented) to be for use during the Emacs > build process. Interactive calls to "update-directory-autoloads" and the > like would be unaffected. > > I think that the comment is wrong, as I use this function outside of the > Emacs build process (and I am sure others do also), so I think we should > remove that. Alternatively, if it is right, we should move it do the > docstring. Fixing the doc string is always a good thing, but it's orthogonal to the issue at hand. (I do agree that the comment is wrong.) > But, I think having a "no backup files" default is still sensible for a > function used in batch; if it is always used this way in the Emacs build, > then it it telling us something. So, I would change it, and update the > docstring. We could also split the function, so that there is a version > which does not suppress backup files. I don't think I agree that batch mode should behave differently wrt backups. How about this alternative: only disable backing up the initial (effectively empty) contents of the autoloads file? AFAICT, the backup files are created during a bootstrap only because we first write the initial "rubric" into it, using write-region, and only after that visit it. This defeats the normal mechanism of backing up just once per session, and leaves a backup file whose contents are not interesting. So an alternative would be to modify autoload-ensure-default-file so that it returns some indication about the fact it created the file, and then change its caller to set buffer-backed-up after it visits the file, thus preventing the backup _only_ when the file is first created. This should at least solve Achim's problem, but without affecting anything else. WDYT?