From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23720: 25.0.94; Issues with GUD (gdb-mi) after upgrade from Emacs 23 to 24/25 Date: Fri, 10 Jun 2016 12:00:07 +0300 Message-ID: <83oa79pgfc.fsf@gnu.org> References: <5756941E.3000700@oracle.com> <837fe0syx5.fsf@gnu.org> <8337oosubh.fsf@gnu.org> <57591DDF.4030900@oracle.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1465549228 13067 80.91.229.3 (10 Jun 2016 09:00:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Jun 2016 09:00:28 +0000 (UTC) Cc: 23720@debbugs.gnu.org To: Guilhem Bichot Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 10 11:00:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bBIIa-0007pS-Bh for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jun 2016 11:00:16 +0200 Original-Received: from localhost ([::1]:39124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBIIZ-0000oe-M0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jun 2016 05:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBIIT-0000lK-3J for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2016 05:00:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBIIN-0001r7-7X for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2016 05:00:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBIIN-0001r3-16 for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2016 05:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bBIIM-0005mt-O0 for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2016 05:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2016 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23720-submit@debbugs.gnu.org id=B23720.146554918022190 (code B ref 23720); Fri, 10 Jun 2016 09:00:02 +0000 Original-Received: (at 23720) by debbugs.gnu.org; 10 Jun 2016 08:59:40 +0000 Original-Received: from localhost ([127.0.0.1]:35119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBIHz-0005lq-VP for submit@debbugs.gnu.org; Fri, 10 Jun 2016 04:59:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBIHw-0005lb-Ef for 23720@debbugs.gnu.org; Fri, 10 Jun 2016 04:59:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBIHm-0001n4-VZ for 23720@debbugs.gnu.org; Fri, 10 Jun 2016 04:59:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBIHm-0001mx-SQ; Fri, 10 Jun 2016 04:59:26 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4361 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bBIHl-00068p-1Z; Fri, 10 Jun 2016 04:59:25 -0400 In-reply-to: <57591DDF.4030900@oracle.com> (message from Guilhem Bichot on Thu, 9 Jun 2016 09:42:23 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119367 Archived-At: > Cc: 23720@debbugs.gnu.org > From: Guilhem Bichot > Date: Thu, 9 Jun 2016 09:42:23 +0200 > > > diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el > > index 5ad101d..195acaf 100644 > > --- a/lisp/progmodes/gdb-mi.el > > +++ b/lisp/progmodes/gdb-mi.el > > @@ -2488,7 +2488,9 @@ gdb-stopped > > ;; Reason is available with target-async only > > (let* ((result (gdb-json-string output-field)) > > (reason (bindat-get-field result 'reason)) > > - (thread-id (bindat-get-field result 'thread-id))) > > + (thread-id (bindat-get-field result 'thread-id)) > > + (retval (bindat-get-field result 'return-value)) > > + (varnum (bindat-get-field result 'gdb-result-var))) > > > > ;; -data-list-register-names needs to be issued for any stopped > > ;; thread > > @@ -2514,6 +2516,11 @@ gdb-stopped > > (if (string-equal reason "exited-normally") > > (setq gdb-active-process nil)) > > > > + (when (and retval varnum) > > + (setq gdb-filter-output > > + (concat gdb-filter-output > > + (format "Value returned is %s = %s\n" varnum retval)))) > > + > > ;; Select new current thread. > > > > ;; Don't switch if we have no reasons selected > > yes, it works! thanks! > Please, could you consider incorporating this into the next releases? It's too late for the next release, which is expected in a few weeks. Besides, I've just discovered that sometimes the "Value returned" message as already produced by GDB/MI, so my naïve change caused it to be produced twice. I pushed a fixed version to the master branch.