From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23785: Emacs 25: "Undo" overdoes things. Date: Fri, 17 Jun 2016 23:07:18 +0300 Message-ID: <83oa6zbmvd.fsf@gnu.org> References: <20160617150245.GB3316@acm.fritz.box> <83r3bvbuu1.fsf@gnu.org> <20160617174535.GD3316@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1466194054 4838 80.91.229.3 (17 Jun 2016 20:07:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2016 20:07:34 +0000 (UTC) Cc: 23785@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 17 22:07:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bE02w-0004qD-Gb for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 22:07:18 +0200 Original-Received: from localhost ([::1]:60119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE02v-0007o9-Lz for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 16:07:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE02l-0007kg-6D for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 16:07:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE02g-0000la-3d for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 16:07:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE02g-0000lQ-08 for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 16:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bE02f-0006UF-OZ for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 16:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2016 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23785-submit@debbugs.gnu.org id=B23785.146619398924894 (code B ref 23785); Fri, 17 Jun 2016 20:07:01 +0000 Original-Received: (at 23785) by debbugs.gnu.org; 17 Jun 2016 20:06:29 +0000 Original-Received: from localhost ([127.0.0.1]:44521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE028-0006TS-NZ for submit@debbugs.gnu.org; Fri, 17 Jun 2016 16:06:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE027-0006TB-H9 for 23785@debbugs.gnu.org; Fri, 17 Jun 2016 16:06:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE01y-0000bt-8C for 23785@debbugs.gnu.org; Fri, 17 Jun 2016 16:06:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE01y-0000bn-5B; Fri, 17 Jun 2016 16:06:18 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4648 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bE01w-0001M4-5F; Fri, 17 Jun 2016 16:06:16 -0400 In-reply-to: <20160617174535.GD3316@acm.fritz.box> (message from Alan Mackenzie on Fri, 17 Jun 2016 17:45:35 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119690 Archived-At: > Date: Fri, 17 Jun 2016 17:45:35 +0000 > Cc: 23785@debbugs.gnu.org > From: Alan Mackenzie > > > > 1. emacs -Q > > > 2. C-x C-f decls-6.cc ; file is attached. > > > 3. Move point to BOL 17. > > > 4. C-o, and insert the line "Type var = init;". Call this line 16½. > > > 5. M-x revert-buffer. > > > 6. Move point to "[" on L16, and use C-M-k to delete "[3 * peq]". > > > 7. C-_. This restores "[3 * peq]" (correctly) but also reinserts line > > > 16½ (which is a bug). > > > Why does this minor issue deserve to declare 'undo' "broken"? Looks > > like an exaggeration to me. > > I don't think it's all that minor an issue. You are being unreasonably subjective on this one. > `undo' can no longer be depended upon to restore a buffer to its > unchanged state. Undo is about undoing changes, and it is documented to lump several changes together in some situations. So your expectations are unreasonably unrealistic to begin with. > Each buffer changing command is meant to have its own undo boundary > (with the exception of self-insert-command and the single character > deleting command). I don't think this is true, and in any case see no big difference between several commands each deleting one character and a single command deleting several characters at once. > I think there's a case to be made for fixing this bug for Emacs 25.1. It depends on what the fix will look like. If it's simple and safe enough, I'll agree.