From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23985: Emacs 25.0.94: FEATURE ADDITION: Texinfo environment movement commands Date: Fri, 15 Jul 2016 10:01:28 +0300 Message-ID: <83oa5z75br.fsf@gnu.org> References: <83poqg6n8l.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1468566190 25989 80.91.229.3 (15 Jul 2016 07:03:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Jul 2016 07:03:10 +0000 (UTC) Cc: 23985@debbugs.gnu.org To: rswgnu@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 15 09:02:59 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNx9G-0004i7-2l for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jul 2016 09:02:58 +0200 Original-Received: from localhost ([::1]:58821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNx9F-0008VJ-BL for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jul 2016 03:02:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNx8Q-00081z-1q for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 03:02:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNx8L-0006ge-Th for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 03:02:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNx8L-0006ga-R4 for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 03:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bNx8L-0001Qp-KL for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 03:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2016 07:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23985-submit@debbugs.gnu.org id=B23985.14685661105475 (code B ref 23985); Fri, 15 Jul 2016 07:02:01 +0000 Original-Received: (at 23985) by debbugs.gnu.org; 15 Jul 2016 07:01:50 +0000 Original-Received: from localhost ([127.0.0.1]:51956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNx8A-0001QF-2l for submit@debbugs.gnu.org; Fri, 15 Jul 2016 03:01:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNx88-0001Pt-IO for 23985@debbugs.gnu.org; Fri, 15 Jul 2016 03:01:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNx80-0006fJ-Ak for 23985@debbugs.gnu.org; Fri, 15 Jul 2016 03:01:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNx80-0006fF-7M; Fri, 15 Jul 2016 03:01:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2757 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bNx7y-0004xV-AC; Fri, 15 Jul 2016 03:01:38 -0400 In-reply-to: (message from Robert Weiner on Thu, 14 Jul 2016 15:43:44 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121107 Archived-At: > From: Robert Weiner > Date: Thu, 14 Jul 2016 15:43:44 -0400 > Cc: 23985@debbugs.gnu.org, bug-texinfo@gnu.org > > On Thu, Jul 14, 2016 at 3:19 PM, Eli Zaretskii wrote: > > Thanks. Allow me a few comments. > > Thanks for the feedback. > > > > >> + ;;; Texinfo environment, e.g. @table, movement commands > >> + ;; Author: Bob Weiner , Orig-Date: 7/14/2016 > >> + ;; Copyright (C) 2016 Free Software Foundation, Inc. > > > > > We don't put such comments into the code, the log entry and AUTHORS > > serve this purpose. > > I just put that in there for the reference of whoever actually patches > the Emacs sources, not to be kept in there. If you send the patch in the form of git-format-patch, those details are taken care for you by Git. > >> + (defun texinfo-to-environment-bounds () > >> + "If within a Texinfo environment with an @end, move point first to its starting line and then to its ending line. > > > > The first line of a doc string should not be wider than 67 characters, > > certainly not more than 78, and it should still be a complete sentence > > that summarizes what the function does. > > It is a sentence and I always make the first line of a doc string > stand alone but often the complexity makes these first lines long. > I then wrap further lines at 78 or less. I will keep this advice in > mind but will no doubt find it hard to be clear and complete with > in such a short space. Clément suggested a shorter wording that would fit. I can suggest another: Go to the beginning or @end of the current Texinfo environment. You don't have to say it all in the first sentence, only the main point of the function. The details are described in the rest of the doc string. > > Other lines should also be broken at character 70. > > Is that really done throughout Emacs? With today's wider screens, I > would think some relaxation would be permitted. Maybe so, but the current guidelines still say the above. Feel free to raise this issue on emacs-devel. Thanks.