From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24706: 26.0.50; Minor mode functions should do strict argument type checking Date: Sun, 16 Oct 2016 21:01:14 +0300 Message-ID: <83oa2kyxzp.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1476640970 5512 195.159.176.226 (16 Oct 2016 18:02:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Oct 2016 18:02:50 +0000 (UTC) Cc: 24706@debbugs.gnu.org, p.stephani2@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 16 20:02:45 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvplH-0005ju-ID for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Oct 2016 20:02:15 +0200 Original-Received: from localhost ([::1]:57368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvplJ-00079K-7O for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Oct 2016 14:02:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvpl8-000777-Uo for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 14:02:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvpl5-0007wP-9N for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 14:02:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bvpl5-0007w9-68 for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 14:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bvpl4-0007DF-Eh for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 14:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Oct 2016 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24706-submit@debbugs.gnu.org id=B24706.147664088627675 (code B ref 24706); Sun, 16 Oct 2016 18:02:02 +0000 Original-Received: (at 24706) by debbugs.gnu.org; 16 Oct 2016 18:01:26 +0000 Original-Received: from localhost ([127.0.0.1]:35377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvpkT-0007CI-KL for submit@debbugs.gnu.org; Sun, 16 Oct 2016 14:01:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvpkS-0007C3-Bs for 24706@debbugs.gnu.org; Sun, 16 Oct 2016 14:01:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvpkM-0007MS-HS for 24706@debbugs.gnu.org; Sun, 16 Oct 2016 14:01:19 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvpkJ-0007JJ-QA; Sun, 16 Oct 2016 14:01:15 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2641 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bvpkI-0000Nd-Ut; Sun, 16 Oct 2016 14:01:15 -0400 In-reply-to: (message from Noam Postavsky on Sun, 16 Oct 2016 12:31:51 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124561 Archived-At: > From: Noam Postavsky > Date: Sun, 16 Oct 2016 12:31:51 -0400 > Cc: 24706@debbugs.gnu.org, Philipp Stephani > > > No, it does not suggest that. But to be clearer, it should > > probably explicitly address the non-nil and non-`toggle' case, > > like so: > > > > If called from Lisp, enable the mode if ARG is omitted or > > nil, toggle it if ARG is ‘toggle’, and disable it if ARG is > > any other non-nil value. > > If the Lisp description is meant to be exhaustive by itself, we should > cover the numeric case too: > > If called from Lisp, enable the mode if ARG is omitted, nil, or a > positive number; toggle it if ARG is `toggle'; and disable it > otherwise. There's a magic word 'also", which should allow us to avoid repetitions.