From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions Date: Mon, 24 Oct 2016 22:46:42 +0300 Message-ID: <83oa2934yl.fsf@gnu.org> References: <20161023191028.10942.12099@vcs.savannah.gnu.org> <20161023191028.C103F220124@vcs.savannah.gnu.org> <83mvhu5kn0.fsf@gnu.org> <8360oh4tnt.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1477338537 14244 195.159.176.226 (24 Oct 2016 19:48:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Oct 2016 19:48:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 24 21:48:53 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bylES-0008Vz-O7 for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2016 21:48:28 +0200 Original-Received: from localhost ([::1]:49509 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bylEV-00030n-4A for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2016 15:48:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bylD5-0002Ao-0b for emacs-devel@gnu.org; Mon, 24 Oct 2016 15:47:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bylD1-0007LU-UU for emacs-devel@gnu.org; Mon, 24 Oct 2016 15:47:03 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bylD1-0007LO-RN; Mon, 24 Oct 2016 15:46:59 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3523 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bylCv-0005k0-Kn; Mon, 24 Oct 2016 15:46:59 -0400 In-reply-to: (message from Stefan Monnier on Mon, 24 Oct 2016 15:01:06 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208742 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Mon, 24 Oct 2016 15:01:06 -0400 > > >> > I think we should consider these nits when we finish fixing the bugs > >> > due to relocation, > >> I think we should not fix those. The constraints imposed by > >> a relocating malloc are too difficult to abide to IMO, so we should just > >> say no. > > It depends on how hard that is. The last one I fixed was very easy. > > How many of us know the constraints? How many of those know them enough to > think about them when making changes? How many of those get the answer > right when thinking about those problems? The same is true for many other parts of Emacs: bidi.c, syntax.c, composite.c, to name just a few. > It's a landmine, just like the gcpros were. Sure. But we're already in the minefield, might as well be careful enough to not step on any mine, until we can get out. > > More generally, as long as even a single platform we care about uses > > ralloc.c, I don't think we can leave those problems unfixed, because > > their effects are so nasty. > > That's why I'm advocating getting rid of it. Same here. Read my messages.