From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24 Date: Tue, 15 Nov 2016 17:20:36 +0200 Message-ID: <83oa1ghirf.fsf@gnu.org> References: <20161115040050.3382-1-spwhitton@spwhitton.name> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1479223464 3016 195.159.176.226 (15 Nov 2016 15:24:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 Nov 2016 15:24:24 +0000 (UTC) Cc: 24944@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 15 16:24:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6faZ-0006Mt-M6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 16:23:59 +0100 Original-Received: from localhost ([::1]:47009 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6fac-0005wv-QU for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 10:24:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6fXm-0004Q8-U8 for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 10:21:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6fXj-00018k-0Y for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 10:21:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42945) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6fXi-00018g-Tv for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 10:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c6fXi-0008Dm-55 for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 10:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2016 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24944 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24944-submit@debbugs.gnu.org id=B24944.147922323631544 (code B ref 24944); Tue, 15 Nov 2016 15:21:02 +0000 Original-Received: (at 24944) by debbugs.gnu.org; 15 Nov 2016 15:20:36 +0000 Original-Received: from localhost ([127.0.0.1]:58344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6fXH-0008Ci-Pc for submit@debbugs.gnu.org; Tue, 15 Nov 2016 10:20:35 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6fXG-0008CV-5b for 24944@debbugs.gnu.org; Tue, 15 Nov 2016 10:20:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6fX4-0000s8-LA for 24944@debbugs.gnu.org; Tue, 15 Nov 2016 10:20:25 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6fX4-0000rs-Gm; Tue, 15 Nov 2016 10:20:22 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3044 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c6fX3-0005Mh-TA; Tue, 15 Nov 2016 10:20:22 -0500 In-reply-to: <20161115040050.3382-1-spwhitton@spwhitton.name> (message from Sean Whitton on Mon, 14 Nov 2016 21:00:50 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125713 Archived-At: > From: Sean Whitton > Date: Mon, 14 Nov 2016 21:00:50 -0700 > Cc: Sean Whitton > > The function `map-length' is not available. > --- > packages/seq/tests/seq-tests.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/packages/seq/tests/seq-tests.el b/packages/seq/tests/seq-tests.el > index 53930fa..7a9a452 100644 > --- a/packages/seq/tests/seq-tests.el > +++ b/packages/seq/tests/seq-tests.el > @@ -351,6 +351,7 @@ Evaluate BODY for each created sequence. > ["xxx" "xx" "x"])))) > > (ert-deftest test-seq-random-elt-take-all () > + (skip-unless (version> emacs-version "25")) > (let ((seq '(a b c d e)) > (count '())) > (should (= 0 (map-length count))) A better test is to use fboundp (after requiring the package that should define it) to probe whether the function exists or not, instead of relying on the version. Thanks.