From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 24944@debbugs.gnu.org
Subject: bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24
Date: Tue, 15 Nov 2016 17:20:36 +0200 [thread overview]
Message-ID: <83oa1ghirf.fsf@gnu.org> (raw)
In-Reply-To: <20161115040050.3382-1-spwhitton@spwhitton.name> (message from Sean Whitton on Mon, 14 Nov 2016 21:00:50 -0700)
> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Mon, 14 Nov 2016 21:00:50 -0700
> Cc: Sean Whitton <spwhitton@spwhitton.name>
>
> The function `map-length' is not available.
> ---
> packages/seq/tests/seq-tests.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/packages/seq/tests/seq-tests.el b/packages/seq/tests/seq-tests.el
> index 53930fa..7a9a452 100644
> --- a/packages/seq/tests/seq-tests.el
> +++ b/packages/seq/tests/seq-tests.el
> @@ -351,6 +351,7 @@ Evaluate BODY for each created sequence.
> ["xxx" "xx" "x"]))))
>
> (ert-deftest test-seq-random-elt-take-all ()
> + (skip-unless (version> emacs-version "25"))
> (let ((seq '(a b c d e))
> (count '()))
> (should (= 0 (map-length count)))
A better test is to use fboundp (after requiring the package that
should define it) to probe whether the function exists or not, instead
of relying on the version.
Thanks.
next prev parent reply other threads:[~2016-11-15 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 4:00 bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24 Sean Whitton
2016-11-15 15:20 ` Eli Zaretskii [this message]
2016-11-15 16:06 ` Sean Whitton
2016-11-15 17:02 ` Nicolas Petton
2016-11-15 17:06 ` Sean Whitton
2016-11-15 20:13 ` Nicolas Petton
2016-11-15 22:44 ` Sean Whitton
2016-11-15 22:58 ` Nicolas Petton
2016-11-16 0:30 ` Sean Whitton
2016-11-16 17:40 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83oa1ghirf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24944@debbugs.gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.