From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24713: 26.0.50; edebug-max-depth should be customizable Date: Sat, 04 Feb 2017 13:05:13 +0200 Message-ID: <83o9yi8bdi.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1486206384 3758 195.159.176.226 (4 Feb 2017 11:06:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 4 Feb 2017 11:06:24 +0000 (UTC) Cc: 24713-done@debbugs.gnu.org To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 04 12:06:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZyAV-0000Vx-Uh for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 12:06:12 +0100 Original-Received: from localhost ([::1]:38753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZyAb-0005sO-8e for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 06:06:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZyAR-0005rG-5M for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:06:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZyAM-0003sO-7t for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:06:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57325) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZyAM-0003sB-4h for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cZyAL-0007v5-Tw for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:06:01 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2017 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24713 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 24713@debbugs.gnu.org, eliz@gnu.org, gazally@runbox.com Original-Received: via spool by 24713-done@debbugs.gnu.org id=D24713.148620633630407 (code D ref 24713); Sat, 04 Feb 2017 11:06:01 +0000 Original-Received: (at 24713-done) by debbugs.gnu.org; 4 Feb 2017 11:05:36 +0000 Original-Received: from localhost ([127.0.0.1]:55523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZy9w-0007uN-4x for submit@debbugs.gnu.org; Sat, 04 Feb 2017 06:05:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZy9u-0007uA-8E for 24713-done@debbugs.gnu.org; Sat, 04 Feb 2017 06:05:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZy9k-0003hY-2i for 24713-done@debbugs.gnu.org; Sat, 04 Feb 2017 06:05:28 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZy9j-0003hU-W3; Sat, 04 Feb 2017 06:05:24 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1320 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZy9j-000259-9X; Sat, 04 Feb 2017 06:05:23 -0500 In-reply-to: (message from Gemini Lasswell on Sun, 16 Oct 2016 14:58:44 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128941 Archived-At: > From: Gemini Lasswell > Date: Sun, 16 Oct 2016 14:58:44 -0700 > > Edebug's recursion limit is currently 150, but this is not enough for > the following files in the Emacs source tree: > > lisp/calc/calc-ext.el > lisp/help-macro.el > lisp/international/fontset.el > > The latter two can be successfully instrumented with edebug-max-depth > set to 200, but the minimum value necessary for calc-ext.el is somewhere > between 500 and 1000. All three of these files contain large quoted > lists. > > I'm attaching a patch to accomplish this. Thanks, pushed. A few minor nits for the future: . when you add/modify a defcustom, always specify a :version tag . please always mention the bug number in the commit log message, otherwise it must be added by hand, which is error-prone . user-visible changes should be accompanied by suitable changes to NEWS and the manuals (I did it this time) . please use the US English convention of leaving 2 spaces between sentences -- this is what we use in Emacs documentation . please configure your Git repo (on Github?) so that your user name is identical to what you use to send email, to avoid confusion