From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25767: 25.1.91; abbrev-prefix-mark expansion inserts newline Date: Sat, 18 Feb 2017 10:09:39 +0200 Message-ID: <83o9xzrkcc.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1487405417 22306 195.159.176.226 (18 Feb 2017 08:10:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2017 08:10:17 +0000 (UTC) Cc: 25767@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 18 09:10:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf05r-0005Or-Hq for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Feb 2017 09:10:11 +0100 Original-Received: from localhost ([::1]:57534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf05x-0006M0-AT for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Feb 2017 03:10:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf05n-0006KV-Co for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 03:10:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf05i-0003YG-F3 for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 03:10:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cf05i-0003YA-Cj for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 03:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cf05i-0001xx-7u for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 03:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2017 08:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25767-submit@debbugs.gnu.org id=B25767.14874053627508 (code B ref 25767); Sat, 18 Feb 2017 08:10:02 +0000 Original-Received: (at 25767) by debbugs.gnu.org; 18 Feb 2017 08:09:22 +0000 Original-Received: from localhost ([127.0.0.1]:44109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf054-0001x2-AD for submit@debbugs.gnu.org; Sat, 18 Feb 2017 03:09:22 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf052-0001wp-Bf for 25767@debbugs.gnu.org; Sat, 18 Feb 2017 03:09:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf04s-0002QQ-93 for 25767@debbugs.gnu.org; Sat, 18 Feb 2017 03:09:15 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf04s-0002QM-5Y; Sat, 18 Feb 2017 03:09:10 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4542 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cf04r-0002iP-9r; Sat, 18 Feb 2017 03:09:09 -0500 In-reply-to: (message from Allen Li on Fri, 17 Feb 2017 14:15:07 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129478 Archived-At: > From: Allen Li > Date: Fri, 17 Feb 2017 14:15:07 -0800 > > The fix is really easy, but I haven't contributed to Emacs before, so > I don't know the proper procedure. The simplest way is to post the patch, as "diff -u output", here. If it's small enough, that's all you need. Bonus points for following the advice in CONTRIBUTE, which you can find in the Emacs repository and in new enough release tarballs. Running the relevant tests in the Emacs test suite (abbrev-tests.el) to make sure the changes cause no regressions is also a plus. > (Also, the existing code really bugs me; I would tear it out and > replace it with (with-excursion) if Emacs was my pet project that > millions of users aren't depending on.) You could post 2 alternative patches (assuming the more radical one passes all the tests in the test suite), and let us judge. Thanks.