From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Sun, 07 May 2017 05:43:23 +0300 Message-ID: <83o9v5e69g.fsf@gnu.org> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87o9v614bl.fsf@calancha-pc> <83y3uadpwf.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494125061 32580 195.159.176.226 (7 May 2017 02:44:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 May 2017 02:44:21 +0000 (UTC) Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com, emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 07 04:44:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7CBF-0008O1-Pg for ged-emacs-devel@m.gmane.org; Sun, 07 May 2017 04:44:17 +0200 Original-Received: from localhost ([::1]:53431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7CBL-0006o3-5k for ged-emacs-devel@m.gmane.org; Sat, 06 May 2017 22:44:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7CAm-0006ny-Vd for emacs-devel@gnu.org; Sat, 06 May 2017 22:43:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7CAj-00084i-Qn for emacs-devel@gnu.org; Sat, 06 May 2017 22:43:48 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7CAj-00084e-Nk; Sat, 06 May 2017 22:43:45 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3750 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d7CAi-0004VZ-Tl; Sat, 06 May 2017 22:43:45 -0400 In-reply-to: (message from Tino Calancha on Sun, 7 May 2017 11:25:41 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214645 Archived-At: > From: Tino Calancha > Date: Sun, 7 May 2017 11:25:41 +0900 (JST) > cc: Tino Calancha , jean.christophe.helary@gmail.com, > mvoteiza@udel.edu, Emacs developers > > >> I find it more legible written as: > >> (string-trim-left > >> (string-trim-right string regexp-end) > >> regexp-beg) > >> > >> than as: > >> (string-trim-left (string-trim-right string regexp-end) regexp-beg) > > > > Again, personal style issue, IMO. > Just wondering what is your personal style here. My personal style is to use the line as much as it allows me. But I generally try not to impose my personal style on work done by others. I think every one of us is entitled to have the code they contributed keep their style.