From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28229: 26.0.50; outline-minor-mode-hook run twice when reverting buffer Date: Fri, 25 Aug 2017 16:08:01 +0300 Message-ID: <83o9r37q32.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1503666564 19657 195.159.176.226 (25 Aug 2017 13:09:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 25 Aug 2017 13:09:24 +0000 (UTC) Cc: 28229@debbugs.gnu.org To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 25 15:09:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlEMC-00047F-FH for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Aug 2017 15:09:04 +0200 Original-Received: from localhost ([::1]:53223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlEMJ-0006K6-5W for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Aug 2017 09:09:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlEMD-0006Jq-Q3 for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2017 09:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlEMA-0005C0-J9 for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2017 09:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45142) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlEMA-0005Bv-Fh for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2017 09:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlEMA-0000Xw-BS for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2017 09:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Aug 2017 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28229 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28229-submit@debbugs.gnu.org id=B28229.15036665342084 (code B ref 28229); Fri, 25 Aug 2017 13:09:02 +0000 Original-Received: (at 28229) by debbugs.gnu.org; 25 Aug 2017 13:08:54 +0000 Original-Received: from localhost ([127.0.0.1]:53823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlEM1-0000XY-TN for submit@debbugs.gnu.org; Fri, 25 Aug 2017 09:08:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlEM0-0000XM-B5 for 28229@debbugs.gnu.org; Fri, 25 Aug 2017 09:08:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlELs-00057O-2W for 28229@debbugs.gnu.org; Fri, 25 Aug 2017 09:08:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlELr-00057G-VR; Fri, 25 Aug 2017 09:08:44 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2644 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dlELp-0004T5-AU; Fri, 25 Aug 2017 09:08:43 -0400 In-reply-to: (message from Kaushal Modi on Fri, 25 Aug 2017 12:14:23 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136193 Archived-At: > From: Kaushal Modi > Date: Fri, 25 Aug 2017 12:14:23 +0000 > > I recently discovered an anomaly with my outline mode customization and it boiled down to this unexplained > behavior.. the outline-minor-mode-hook was getting triggered twice on doing revert-buffer. Isn't this expected behavior? revert-buffer calls normal-mode, which first kills all local variables, which involves turning off outline-minor-mode by calling (outline-minor-mode -1) And that calls your hook. The other time is when normal-mode turns outline-minor-mode ON. The doc string of outline-minor-mode-hook (and any other hook created by define-minor-mode) clearly says: Hook run after entering or leaving ‘outline-minor-mode’.