From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Date: Fri, 13 Oct 2017 16:43:33 +0300 Message-ID: <83o9pbjh8b.fsf@gnu.org> References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> <871sm7b356.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507902314 16096 195.159.176.226 (13 Oct 2017 13:45:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Oct 2017 13:45:14 +0000 (UTC) Cc: 28797@debbugs.gnu.org, tino.calancha@gmail.com, kaushal.modi@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 13 15:45:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e30Gu-00037d-RE for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 15:45:04 +0200 Original-Received: from localhost ([::1]:50405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e30H2-0007LF-90 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 09:45:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e30Gx-0007L8-5v for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e30Gs-00024s-8w for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:45:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56585) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e30Gs-00024f-5Y for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e30Gr-0001Gb-Sd for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 13:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.15079022434763 (code B ref 28797); Fri, 13 Oct 2017 13:45:01 +0000 Original-Received: (at 28797) by debbugs.gnu.org; 13 Oct 2017 13:44:03 +0000 Original-Received: from localhost ([127.0.0.1]:37032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e30Fv-0001Ek-Gb for submit@debbugs.gnu.org; Fri, 13 Oct 2017 09:44:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e30Ft-0001Dx-AP for 28797@debbugs.gnu.org; Fri, 13 Oct 2017 09:44:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e30Fj-00017G-92 for 28797@debbugs.gnu.org; Fri, 13 Oct 2017 09:43:56 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e30FY-0000sm-TO; Fri, 13 Oct 2017 09:43:40 -0400 Original-Received: from [176.228.60.248] (port=2107 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e30FY-0004yZ-AE; Fri, 13 Oct 2017 09:43:40 -0400 In-reply-to: <871sm7b356.fsf@users.sourceforge.net> (message from Noam Postavsky on Fri, 13 Oct 2017 09:15:01 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138343 Archived-At: > From: Noam Postavsky > Cc: 28797@debbugs.gnu.org, tino.calancha@gmail.com, kaushal.modi@gmail.com > Date: Fri, 13 Oct 2017 09:15:01 -0400 > > Eli Zaretskii writes: > > >> Here's a patch, uses error-message-string for #1, > > > > This doesn't handle all of the parts of the complaint, does it? > > The resulting error will look like > > file-error: Non-regular file: Is a directory, /home/kmodi/.emacs.d/foo > > It's not quite the perfect sentence envisioned on the OP, but it gets > all the information across, with punctuation separating the parts. OK, close enough for me. > >> condition-case-unless-debug for #2. > > > > This is quite a radical change in very old behavior, so if it is > > deemed a good idea, it should go to master. > > Hmm, it doesn't seem that radical to me, but I don't have a problem > putting it only to master, or even not doing that at all and just saying > the user should use debug-on-signal. It's radical because we never produce backtrace in similar cases anywhere else in Emacs. Let's wait to hear what others think about this part. Thanks.