From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30320: 26.0.91; Crash when using lsp-ui-doc-mode Date: Sun, 11 Feb 2018 17:43:13 +0200 Message-ID: <83o9kv1qi6.fsf@gnu.org> References: <83po5oeil8.fsf@gnu.org> <83a7wrer8i.fsf@gnu.org> <5A757B30.9070402@gmx.at> <83y3ka9gmg.fsf@gnu.org> <83mv0pal74.fsf@gnu.org> <83y3k88ux5.fsf@gnu.org> <834lmv8j3u.fsf@gnu.org> <5A797560.9000602@gmx.at> <83mv0h2ltf.fsf@gnu.org> <5A7ECD34.6000604@gmx.at> <834lmp2gex.fsf@gnu.org> <5A7EF644.5030706@gmx.at> <8337283im3.fsf@gnu.org> <5A800E8A.8020807@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518363770 20356 195.159.176.226 (11 Feb 2018 15:42:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Feb 2018 15:42:50 +0000 (UTC) Cc: 30320@debbugs.gnu.org, jake.goulding@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 11 16:42:45 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ektlb-0002yy-T8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Feb 2018 16:42:12 +0100 Original-Received: from localhost ([::1]:51948 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ektnb-0003aV-NI for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Feb 2018 10:44:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ektnT-0003Zf-DL for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2018 10:44:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ektnO-0005De-Mj for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2018 10:44:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ektnO-0005DV-JW for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2018 10:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ektnO-00020z-Dk for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2018 10:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Feb 2018 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30320 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30320-submit@debbugs.gnu.org id=B30320.15183638227712 (code B ref 30320); Sun, 11 Feb 2018 15:44:02 +0000 Original-Received: (at 30320) by debbugs.gnu.org; 11 Feb 2018 15:43:42 +0000 Original-Received: from localhost ([127.0.0.1]:38482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ektn2-00020G-IE for submit@debbugs.gnu.org; Sun, 11 Feb 2018 10:43:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ektn0-000203-2J for 30320@debbugs.gnu.org; Sun, 11 Feb 2018 10:43:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ektmq-0004LX-2W for 30320@debbugs.gnu.org; Sun, 11 Feb 2018 10:43:32 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ektmp-0004LG-VU; Sun, 11 Feb 2018 10:43:27 -0500 Original-Received: from [176.228.60.248] (port=4982 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ektmp-0006Ga-As; Sun, 11 Feb 2018 10:43:27 -0500 In-reply-to: <5A800E8A.8020807@gmx.at> (message from martin rudalics on Sun, 11 Feb 2018 10:36:10 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143138 Archived-At: > Date: Sun, 11 Feb 2018 10:36:10 +0100 > From: martin rudalics > CC: jake.goulding@gmail.com, 30320@debbugs.gnu.org > > --- a/src/frame.c > +++ b/src/frame.c > @@ -350,10 +350,13 @@ struct frame * > struct frame *f = XFRAME (frame); > Lisp_Object par_size; > > - if ((!NILP (horizontal) > - && NUMBERP (par_size = get_frame_param (f, Qmin_width))) > - || (NILP (horizontal) > - && NUMBERP (par_size = get_frame_param (f, Qmin_height)))) > + /* The 'min-width' and 'min-height' parameters have no effect on TTY > + frames. */ > + if (!(FRAME_TERMCAP_P (f) || FRAME_MSDOS_P (f)) > + && ((!NILP (horizontal) > + && NUMBERP (par_size = get_frame_param (f, Qmin_width))) > + || (NILP (horizontal) > + && NUMBERP (par_size = get_frame_param (f, Qmin_height))))) > { > int min_size = XINT (par_size); So you are saying that frame-windows-min-size will never return too small values, at least not for TTY frames? If so, this LGTM, thanks. I just hoped Jake would be able to test this with the original Lisp that caused the problems.