From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: netsec 682578f 4/6: Add option to bypass NSM TLS checks on local networks Date: Mon, 16 Jul 2018 20:59:48 +0300 Message-ID: <83o9f783jf.fsf@gnu.org> References: <20180714170806.8972.58581@vcs0.savannah.gnu.org> <20180714170809.C3A3920456@vcs0.savannah.gnu.org> <87o9f84t89.fsf@gmail.com> <4C758D1D-7C3A-425A-852F-75E03C779E01@gmail.com> <87va9fs3ro.fsf@gmail.com> <83tvoz8bus.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1531763869 16548 195.159.176.226 (16 Jul 2018 17:57:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Jul 2018 17:57:49 +0000 (UTC) Cc: rpluim@gmail.com, emacs-devel@gnu.org To: Jimmy Yuen Ho Wong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 16 19:57:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ff7kl-000495-VR for ged-emacs-devel@m.gmane.org; Mon, 16 Jul 2018 19:57:44 +0200 Original-Received: from localhost ([::1]:53065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ff7mr-0005wU-0j for ged-emacs-devel@m.gmane.org; Mon, 16 Jul 2018 13:59:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ff7mh-0005wD-Pq for emacs-devel@gnu.org; Mon, 16 Jul 2018 13:59:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ff7me-0003RC-OA for emacs-devel@gnu.org; Mon, 16 Jul 2018 13:59:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ff7me-0003R6-K3; Mon, 16 Jul 2018 13:59:40 -0400 Original-Received: from [176.228.60.248] (port=4993 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ff7me-00012B-0u; Mon, 16 Jul 2018 13:59:40 -0400 In-reply-to: (message from Jimmy Yuen Ho Wong on Mon, 16 Jul 2018 16:24:45 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227472 Archived-At: > From: Jimmy Yuen Ho Wong > Date: Mon, 16 Jul 2018 16:24:45 +0100 > Cc: Robert Pluim , Emacs-Devel devel > > > > + ret = getaddrinfo (SSDATA (name), NULL, &hints, &res); > > > > You should encode NAME (using ENCODE_SYSTEM), because it could include > > non-ASCII characters. In general, any Lisp string should be encoded > > before you can pass its data to a C library function. > > > > Does getaddrinfo accept unicode hostnames? If not I think we can just > make sure NAME is all ASCII as per Punycode for i18nized host names. That's fine with me, but my point is that simply plugging the string data into a libc function is usually not OK.