From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: netsec 682578f 4/6: Add option to bypass NSM TLS checks on local networks Date: Tue, 17 Jul 2018 18:50:08 +0300 Message-ID: <83o9f57tfz.fsf@gnu.org> References: <20180714170806.8972.58581@vcs0.savannah.gnu.org> <20180714170809.C3A3920456@vcs0.savannah.gnu.org> <87o9f84t89.fsf@gmail.com> <4C758D1D-7C3A-425A-852F-75E03C779E01@gmail.com> <87va9fs3ro.fsf@gmail.com> <83tvoz8bus.fsf@gnu.org> <87fu0jrvye.fsf@gmail.com> <83in5f833i.fsf@gnu.org> <87pnzm8989.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1531842535 28154 195.159.176.226 (17 Jul 2018 15:48:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Jul 2018 15:48:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 17 17:48:51 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffSDa-0007Cu-DO for ged-emacs-devel@m.gmane.org; Tue, 17 Jul 2018 17:48:50 +0200 Original-Received: from localhost ([::1]:60087 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffSFh-00047B-EK for ged-emacs-devel@m.gmane.org; Tue, 17 Jul 2018 11:51:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffSEi-00042y-PA for emacs-devel@gnu.org; Tue, 17 Jul 2018 11:50:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffSEf-0003cm-JD for emacs-devel@gnu.org; Tue, 17 Jul 2018 11:50:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffSEf-0003cd-FG; Tue, 17 Jul 2018 11:49:57 -0400 Original-Received: from [176.228.60.248] (port=1852 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ffSEe-0003T2-Sa; Tue, 17 Jul 2018 11:49:57 -0400 In-reply-to: <87pnzm8989.fsf@gmail.com> (message from Robert Pluim on Tue, 17 Jul 2018 12:09:10 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227500 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Tue, 17 Jul 2018 12:09:10 +0200 > > Eli Zaretskii writes: > > > > Then I think we should test that it's either a unibyte string or a > > string whose size in bytes is equal to its size in characters, and > > signal an error if that doesn't hold. > > So I tried using STRING_MULTIBYTE, but of course eww uses > puny-encode-domain on unicode hostnames, and that returns a multibyte > string that only contains ASCII characters. Rather than opening that > can of worms, I settled on checking > > SBYTES (host) != SCHARS (host) This will signal an error for unibyte strings, because there SBYTES is always -1. So I think you should do this instead: STRING_MULTIBYTE (host) && SBYTES (host) != SCHARS (host) > I couldn't find an "is this a pure-ASCII string" function. It is rarely needed, IME.