Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files

Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files

[Robert Pluim]

sds@gnu.org (Sam Steingold) writes:

> branch: master
> commit 2d54710c36c8b5f7e0d25eefd45c318c0cb533ea
> Author: Sam Steingold <sds@gnu.org>
> Commit: Sam Steingold <sds@gnu.org>
>
>     lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files

So before 'stash' stashed all modified files, and now it only stashes
marked files? (what does it do if no files are marked?) If thatʼs an
accurate statement, this needs to be called out in NEWS.

Regards

Robert

Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files

[Sam Steingold]

If no files are marked, it stashes all modifications - like it did before.
I did not think such a minor change warrants a NEWS mention.
I will modify NEWS unless told otherwise soon.
(please keep me in CC, I have problems reading the list ATM).
Thanks.

On Fri, Sep 28, 2018 at 11:07 AM, Robert Pluim <rpluim@gmail.com> wrote:
> sds@gnu.org (Sam Steingold) writes:
>
>> branch: master
>> commit 2d54710c36c8b5f7e0d25eefd45c318c0cb533ea
>> Author: Sam Steingold <sds@gnu.org>
>> Commit: Sam Steingold <sds@gnu.org>
>>
>>     lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files
>
> So before 'stash' stashed all modified files, and now it only stashes
> marked files? (what does it do if no files are marked?) If thatʼs an
> accurate statement, this needs to be called out in NEWS.
>
> Regards
>
> Robert



-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>

Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files

[Robert Pluim]

Sam Steingold <sds@gnu.org> writes:

> If no files are marked, it stashes all modifications - like it did before.
> I did not think such a minor change warrants a NEWS mention.
> I will modify NEWS unless told otherwise soon.

A behaviour change is a behaviour change, however minor.

Regards

Robert

Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Date: Sat, 29 Sep 2018 14:10:35 +0200
> Cc: emacs-devel@gnu.org
> 
> Sam Steingold <sds@gnu.org> writes:
> 
> > If no files are marked, it stashes all modifications - like it did before.
> > I did not think such a minor change warrants a NEWS mention.
> > I will modify NEWS unless told otherwise soon.
> 
> A behaviour change is a behaviour change, however minor.

Indeed.