From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: dr.khaled.hosny@gmail.com, ebraminio@gmail.com,
behdad@behdad.org, johnw@gnu.org, far.nasiri.m@gmail.com,
emacs-devel@gnu.org, handa@gnu.org
Subject: Re: Emacs text shaping using Harfbuzz
Date: Thu, 13 Dec 2018 21:48:24 +0200 [thread overview]
Message-ID: <83o99pgqd3.fsf@gnu.org> (raw)
In-Reply-To: <241e97ba-e547-9184-b798-1692be469740@cs.ucla.edu> (message from Paul Eggert on Thu, 13 Dec 2018 10:47:18 -0800)
> Cc: Khaled Hosny <dr.khaled.hosny@gmail.com>,
> Ebrahim Byagowi <ebraminio@gmail.com>, Kenichi Handa <handa@gnu.org>,
> John Wiegley <johnw@gnu.org>, Mohammad Nasirifar <far.nasiri.m@gmail.com>,
> Behdad Esfahbod <behdad@behdad.org>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Thu, 13 Dec 2018 10:47:18 -0800
>
> The Emacs harfbuzz branch built fine for me on Fedora 29 (no surprise).
> I saw no problems, not that I would catch many (the Arabic I saw
> displayed OK to me, but I don't read Arabic so am not the best person to
> judge).
Thanks for trying the branch.
> One minor tweak proposed in the attached patch, for simplicity/clarity
> in the mainstream-Harbuzz code.
IMO, for such obviously correct fixes, you should just go ahead and
push.
> I see that Harbuzz is disabled by default by 'configure', and that
> there's an environment variable to disable it at runtime. I propose
> removing the environment variable, and enabling Harfbuzz by default at
> 'configure' time (if the Harbuzz libraries are available), as I don't
> see much point in nudging users away from Harfbuzz.
I agree to enabling it by default if the necessary libraries are
found.
As for disabling at run time, I think this should be reworked to use
the same framework as with other font back-ends, which can be disabled
at runtime by invoking Emacs with the appropriate -xrm switch. AFAIU,
currently the Harfbuzz code just piggy-backs xftfont, but it really
should be a separate font backend, IMO.
> I see there are some FIXMEs and suchlike comments. Will someone be
> working on them?
I very much hope so ;-) The branch is supposed to be WIP, not a
finished result, not yet anyway.
next prev parent reply other threads:[~2018-12-13 19:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:39 Emacs text shaping using Harfbuzz Eli Zaretskii
2018-12-13 18:47 ` Paul Eggert
2018-12-13 19:31 ` Khaled Hosny
2018-12-13 19:48 ` Eli Zaretskii [this message]
2018-12-13 20:01 ` Eli Zaretskii
2018-12-13 20:23 ` Eli Zaretskii
2018-12-13 19:38 ` Kaushal Modi
2018-12-13 19:48 ` Paul Eggert
2018-12-13 19:55 ` Eli Zaretskii
2018-12-13 20:01 ` Kaushal Modi
2018-12-13 21:16 ` Richard Stallman
2018-12-13 21:43 ` Ken Brown
2018-12-13 23:23 ` Eric Abrahamsen
2018-12-14 0:55 ` Amin Bandali
2018-12-14 7:41 ` Eli Zaretskii
2018-12-14 14:40 ` Basil L. Contovounesios
2018-12-14 14:55 ` Eli Zaretskii
2018-12-14 7:40 ` Eli Zaretskii
2018-12-14 7:35 ` Eli Zaretskii
2018-12-14 1:11 ` Florian Beck
2018-12-14 2:35 ` Kaushal Modi
2018-12-14 7:46 ` Eli Zaretskii
2018-12-15 0:49 ` Paul Eggert
2018-12-16 14:09 ` Benjamin Riefenstahl
2018-12-16 15:27 ` Eli Zaretskii
2018-12-16 17:27 ` Mike Kupfer
2018-12-16 17:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o99pgqd3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=behdad@behdad.org \
--cc=dr.khaled.hosny@gmail.com \
--cc=ebraminio@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=far.nasiri.m@gmail.com \
--cc=handa@gnu.org \
--cc=johnw@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.