bug#34225: 27.0.50; Add passwd backups to etc-passwd-generic-mode

bug#34225: 27.0.50; Add passwd backups to etc-passwd-generic-mode

[Juri Linkov]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

Tags: patch

I don't know why backups /etc/passwd- use the suffix ‘-’ instead of ‘~’
but comparing these files with their backups I noticed the difference
in their font-lock highlighting, thus this patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: generic-x.etc-passwd-generic-mode.patch --]
[-- Type: text/x-diff, Size: 455 bytes --]

diff --git a/lisp/generic-x.el b/lisp/generic-x.el
index 014379fba9..dd61402015 100644
--- a/lisp/generic-x.el
+++ b/lisp/generic-x.el
@@ -1490,7 +1490,7 @@ etc-passwd-generic-mode
      '("^\\([^:]+\\):\\([^:]*\\):\\([0-9]+\\):\\(.*\\)$"
        (1 font-lock-type-face)
        (4 font-lock-variable-name-face))))
-  '("/etc/passwd\\'" "/etc/group\\'")
+  '("/etc/passwd-?\\'" "/etc/group-?\\'" "/etc/shadow-?\\'")
   (list
    (function
     (lambda ()

bug#34225: 27.0.50; Add passwd backups to etc-passwd-generic-mode

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 27 Jan 2019 22:34:03 +0200
> 
> I don't know why backups /etc/passwd- use the suffix ‘-’ instead of ‘~’

It does?  I seem to be unable to reproduce this:

  (make-backup-file-name "/etc/passwd")
    => "/etc/passwd~"

What am I missing?

bug#34225: 27.0.50; Add passwd backups to etc-passwd-generic-mode

[Glenn Morris]

Eli Zaretskii wrote:

>> I don't know why backups /etc/passwd- use the suffix '-' instead of '~'
>
> It does?  I seem to be unable to reproduce this:
>
>   (make-backup-file-name "/etc/passwd")
>     => "/etc/passwd~"
>
> What am I missing?

These are non-Emacs backups. See eg "man 5 shadow".
 
    /etc/shadow-
    Backup file for /etc/shadow.
    
    Note that this file is used by the tools of the shadow toolsuite,
    but not by all user and password management tools.

bug#34225: 27.0.50; Add passwd backups to etc-passwd-generic-mode

[Juri Linkov]

>>> I don't know why backups /etc/passwd- use the suffix '-' instead of '~'
>>
>> It does?  I seem to be unable to reproduce this:
>>
>>   (make-backup-file-name "/etc/passwd")
>>     => "/etc/passwd~"
>>
>> What am I missing?
>
> These are non-Emacs backups. See eg "man 5 shadow".
>
>     /etc/shadow-
>     Backup file for /etc/shadow.
>
>     Note that this file is used by the tools of the shadow toolsuite,
>     but not by all user and password management tools.

Yes, and "man 5 passwd" shows the same:

       /etc/passwd-
           Backup file for /etc/passwd.

So I installed the patch to master.

bug#34225: 27.0.50; Add passwd backups to etc-passwd-generic-mode

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: Eli Zaretskii <eliz@gnu.org>,  34225-done@debbugs.gnu.org
> Date: Mon, 28 Jan 2019 22:19:39 +0200
> 
> >     /etc/shadow-
> >     Backup file for /etc/shadow.
> >
> >     Note that this file is used by the tools of the shadow toolsuite,
> >     but not by all user and password management tools.
> 
> Yes, and "man 5 passwd" shows the same:
> 
>        /etc/passwd-
>            Backup file for /etc/passwd.
> 
> So I installed the patch to master.

Please add a comment there to explain why we do such a strange thing.