From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: branch master segfault (2019-02-05) Date: Wed, 06 Feb 2019 18:45:08 +0200 Message-ID: <83o97osw6j.fsf@gnu.org> References: <83ftt2tc0e.fsf@gnu.org> <83y36ssyzq.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="166686"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Philippe Vaucher Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 06 17:45:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1grQKM-000hGQ-Ih for ged-emacs-devel@m.gmane.org; Wed, 06 Feb 2019 17:45:34 +0100 Original-Received: from localhost ([127.0.0.1]:53692 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grQKL-0004Ei-II for ged-emacs-devel@m.gmane.org; Wed, 06 Feb 2019 11:45:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grQKC-0004DB-QW for emacs-devel@gnu.org; Wed, 06 Feb 2019 11:45:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grQK8-00069C-VK; Wed, 06 Feb 2019 11:45:21 -0500 Original-Received: from [176.228.60.248] (port=1174 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1grQK6-00015s-UG; Wed, 06 Feb 2019 11:45:19 -0500 In-reply-to: (message from Philippe Vaucher on Wed, 6 Feb 2019 17:23:11 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233053 Archived-At: > From: Philippe Vaucher > Date: Wed, 6 Feb 2019 17:23:11 +0100 > Cc: Emacs developers > > > I know docker allocates a "pseudo TTY", so probably that there's a misdetection happening here. > > No, it isn't misdetection. The problem is that safe_terminal_coding > is not set up. > > Your patch works, thanks! > > Just curious, does that mean that in "normal terminals" (not docker) it uses `FRAME_TERMINAL_CODING (f) > ` but in docker it uses `safe_terminal_coding`? Looks like that, yes. It would mean that the docker doesn't define a locale environment which defines a usable codeset. I know nothing about dockers, so I have no idea how could this happen. > If yes, why does it also work in Docker when using `FRAME_TERMINAL_CODING (f)`? Because the terminal encoding was set up, whereas safe_terminal_coding wasn't. In Emacs 26, safe_terminal_coding kept its value initialized in temacs and recorded by unexec, but with pdumper that doesn't happen, so safe_terminal_coding started as all-zero, as any other static variable.