From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34655: 26.1.92; Segfault in module with --module-assertions Date: Thu, 21 Mar 2019 21:27:25 +0200 Message-ID: <83o964t4de.fsf@gnu.org> References: <874l8r1t3a.fsf@tcd.ie> <8336oamu3y.fsf@gnu.org> <87h8c1cv6l.fsf@tcd.ie> <83lg1dwhse.fsf@gnu.org> <87va0h12js.fsf@tcd.ie> <835zsgw3ui.fsf@gnu.org> <87ef7486h0.fsf@tcd.ie> <83r2b4ul1c.fsf@gnu.org> <831s30upqd.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="90879"; mail-complaints-to="usenet@blaine.gmane.org" Cc: contovob@tcd.ie, 34655@debbugs.gnu.org, monnier@iro.umontreal.ca To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 21 20:42:46 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h73aN-000NSf-Pa for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 20:42:43 +0100 Original-Received: from localhost ([127.0.0.1]:45828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h73aM-0000Kg-Dy for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 15:42:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h73UL-00034u-Ou for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 15:36:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h73MA-0001DR-Q1 for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 15:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40073) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h73MA-0001Bi-Dc for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 15:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h73MA-00074T-6S for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 15:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Mar 2019 19:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34655 X-GNU-PR-Package: emacs Original-Received: via spool by 34655-submit@debbugs.gnu.org id=B34655.155319645827152 (code B ref 34655); Thu, 21 Mar 2019 19:28:02 +0000 Original-Received: (at 34655) by debbugs.gnu.org; 21 Mar 2019 19:27:38 +0000 Original-Received: from localhost ([127.0.0.1]:53617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h73Lm-00073s-FA for submit@debbugs.gnu.org; Thu, 21 Mar 2019 15:27:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h73Lk-00073d-Jp for 34655@debbugs.gnu.org; Thu, 21 Mar 2019 15:27:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h73Le-0000O3-Vx; Thu, 21 Mar 2019 15:27:31 -0400 Original-Received: from [176.228.60.248] (port=2479 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h73La-0002Y2-F8; Thu, 21 Mar 2019 15:27:28 -0400 In-reply-to: (message from Philipp Stephani on Thu, 21 Mar 2019 19:28:07 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156580 Archived-At: > > I will CC Stefan, who committed 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a. > > > > I'm not sure we should revert that; we could instead add GC protection > > for those parts that need it. > > Yes, that's what reverting that commit does :-) AFAIU, it does much more. Stefan intended for the conservative stack marking to do the job, so maybe there's a little more that should be done to get there. Or maybe Stefan didn't consider some important factor(s). In either case, I'd like to hear his POV on this before we decide how to proceed. > We need to mark the objects in all cases, not just when module > assertions are enabled. If we get stack marking to work, we won't need to mark objects explicitly. > Note that both the designer of the module API (Daniel) and I as one of > its main implementers disagree with commit > 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a. OK, but I think Stefan's opinion is not less important. > I've already confirmed that reverting commit > 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a fixes bug#31238, and I can > try it with this bug as well. Please do, it's important to know that, I think. Thanks.