From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 30 Mar 2019 13:07:36 +0300 Message-ID: <83o95sisk7.fsf@gnu.org> References: <87wokp4okn.fsf@gmail.com> <83ef6xpo6b.fsf@gnu.org> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <871s2w510a.fsf@gmail.com> <922F9B91-2E9E-45F6-BB96-66CAE5E9FB81@gnu.org> <87k1goqpnn.fsf@gmail.com> <83imw8nspc.fsf@gnu.org> <87ftrcqg5j.fsf@gmail.com> <83bm20nm62.fsf@gnu.org> <87d0men4jx.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256139"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 30 11:07:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAAto-0014XS-26 for ged-emacs-devel@m.gmane.org; Sat, 30 Mar 2019 11:07:40 +0100 Original-Received: from localhost ([127.0.0.1]:54878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAAtm-0004MH-NH for ged-emacs-devel@m.gmane.org; Sat, 30 Mar 2019 06:07:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAAtg-0004M0-V7 for emacs-devel@gnu.org; Sat, 30 Mar 2019 06:07:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAAtg-00089N-OX; Sat, 30 Mar 2019 06:07:32 -0400 Original-Received: from [176.228.60.248] (port=2232 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hAAtf-0004yx-Sv; Sat, 30 Mar 2019 06:07:32 -0400 In-reply-to: <87d0men4jx.fsf@gmail.com> (message from Alex on Mon, 25 Mar 2019 13:21:22 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234818 Archived-At: > From: Alex > Cc: emacs-devel@gnu.org > Date: Mon, 25 Mar 2019 13:21:22 -0600 > > Eli Zaretskii writes: > > > Maybe you are right. How about making a list of those functions > > first? When I looked at them, my impression was that most of them > > _are_ related to display, but maybe I was wrong. We can decide once > > we see the list. > > Alright, I got most of the grunt work done. Thanks (and apologies for not getting to respond earlier). > There are three left in xdisp.c: > > ** x_clear_under_internal_border > ** x_change_tool_bar_height > ** x_implicitly_set_name > > Here are those called in frame.{c, h} > > ** x_set_scroll_bar_default_{width, height} > ** x_set_frame_alpha > ** x_bitmap_icon > ** x_new_font > ** x_set_offset > ** x_set_window_size > ** x_focus_frame > ** x_make_frame_(in)visible > ** x_iconify_frame > > This one is called in image.c: > ** x_query_color(s) So why do you prefer not to add this to redisplay_interface? We could, of course, invent a new struct and a new macro, but we'd be reinventing the FRAME_RIF stuff anyway: the result will most probably look identical to FRAME_RIF, except for names. Is that worth our while? > This one is called in keyboard.c: > ** x_get_keysym_name This one should simply be renamed without the x_ prefix, I think. > I'm not sure what purpose x_get_keysym_name serves (see the comment in > nsterm.m's implementation). Let's leave that specific issue for another time for now. > >> Where would be the best place to add the obsolete aliases? > > > > lisp/term/common-win.el, perhaps? > > Oh, I figured I couldn't use that because of the `pc' window system, but > it looks like that one doesn't set HAVE_WINDOW_SYSTEM, confusingly > enough. It's due to some ancient history: once upon a time, text terminals couldn't use colors, menus, and the mouse, whereas the MSDOS port did that from day one. Thanks.