From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Mon, 15 Apr 2019 17:25:11 +0300 Message-ID: <83o957ibw8.fsf@gnu.org> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> <1555180119.2579.0@yandex.ru> <83k1fxk91r.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="98439"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org, hi-angel@yandex.ru To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 15 16:27:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hG2Zg-000PQs-1A for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 16:27:08 +0200 Original-Received: from localhost ([127.0.0.1]:51031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG2Zf-0001Ei-0a for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 10:27:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG2Yd-0000X5-KB for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 10:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG2Yc-0000mr-OK for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 10:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hG2Yc-0000md-IR for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 10:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hG2Yc-0008Q4-AZ for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 10:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2019 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155533835232346 (code B ref 35062); Mon, 15 Apr 2019 14:26:02 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 15 Apr 2019 14:25:52 +0000 Original-Received: from localhost ([127.0.0.1]:35208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG2YS-0008Pd-2o for submit@debbugs.gnu.org; Mon, 15 Apr 2019 10:25:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG2YQ-0008PN-Cn for 35062@debbugs.gnu.org; Mon, 15 Apr 2019 10:25:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG2YK-0000c2-RI; Mon, 15 Apr 2019 10:25:44 -0400 Original-Received: from [176.228.60.248] (port=2512 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hG2YD-0000E8-7s; Mon, 15 Apr 2019 10:25:37 -0400 In-reply-to: (message from Richard Stallman on Sun, 14 Apr 2019 23:38:51 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157658 Archived-At: > From: Richard Stallman > Cc: hi-angel@yandex.ru, 35062@debbugs.gnu.org > Date: Sun, 14 Apr 2019 23:38:51 -0400 > > > "Suggested by" means you suggested a code > > change, but I tweaked it enough to feel that you can no longer be held > > responsible for whatever mistakes I might have made in the actual code > > change I committed. > > I think you're saying that "suggested by" means that the code changes > were suggested by that person -- not merely that the idea was > suggested by per. Is that it? It could mean either one, actually. We have only a small number of attributions that change-log-mode highlights: "Reported by", "Suggested by", and "Patches by" (each one with a couple of variants). So "Suggested by" will have to serve both when someone just describes an idea and when they submit code from which only the main ideas are taken. If someone wants to know what exactly was "suggested", they need to read the relevant discussions. In this case, the log message references a bug number, and there one can see the actual submission.