From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35739: Bad signature from GNU ELPA Date: Wed, 22 May 2019 08:19:09 +0300 Message-ID: <83o93v83si.fsf@gnu.org> References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38880"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 22 07:43:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTK1p-0009sy-D4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 07:43:05 +0200 Original-Received: from localhost ([127.0.0.1]:36660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTK1o-0002pI-0z for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 01:43:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTJfX-000806-OM for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 01:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTJfW-0001Th-Lf for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 01:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTJfW-0001TW-IG for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 01:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTJfW-0002Xq-C9 for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 01:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2019 05:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35739 X-GNU-PR-Package: emacs Original-Received: via spool by 35739-submit@debbugs.gnu.org id=B35739.15585023529701 (code B ref 35739); Wed, 22 May 2019 05:20:02 +0000 Original-Received: (at 35739) by debbugs.gnu.org; 22 May 2019 05:19:12 +0000 Original-Received: from localhost ([127.0.0.1]:41397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTJeh-0002WP-Id for submit@debbugs.gnu.org; Wed, 22 May 2019 01:19:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTJef-0002WD-UQ for 35739@debbugs.gnu.org; Wed, 22 May 2019 01:19:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTJea-0000UD-J2; Wed, 22 May 2019 01:19:04 -0400 Original-Received: from [176.228.60.248] (port=4840 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTJeZ-0004kR-SG; Wed, 22 May 2019 01:19:04 -0400 In-reply-to: (message from Stefan Monnier on Sat, 18 May 2019 18:36:50 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159628 Archived-At: > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Sat, 18 May 2019 18:36:50 -0400 > > > I don't know. I don't yet have a handle on what happens here, and > > therefore I don't understand how replacing url-insert-buffer-contents > > with url-insert should fix that. I'm probably missing something. > > After playing some more with it, I found a few problems, tracked down > the origin of the decoding (which was introduced for the case where we > download the -readme.txt description file) and installed a patch > into master which should fix this right. > > Now the question is how to adapt the fix for emacs-26: the patch > I installed is too invasive for emacs-26, I think. > > Maybe we can patch over the problem by using `last-coding-system` instead > of `utf-8`? I don't think I understand the change enough to say something intelligent here. The commit explains, o some extent, why the original code failed, but it says nothing about the way the new code solves the problem without introducing new ones. I'm also mildly worried about the incompatible change in url-insert, which is a general-purpose function not limited to package.el and its signature verification.