From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: set-frame-size should respect line-spacing!? Date: Sat, 12 Oct 2019 10:00:14 +0300 Message-ID: <83o8ymo3cx.fsf@gnu.org> References: <87blun57wt.fsf@kenko.localhost.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="242736"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ingo Lohmar Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 12 09:00:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJBOE-001119-50 for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2019 09:00:34 +0200 Original-Received: from localhost ([::1]:59172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJBOC-0008Vn-7n for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2019 03:00:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47361) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJBO5-0008VV-Bz for emacs-devel@gnu.org; Sat, 12 Oct 2019 03:00:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJBO5-0008U1-4k; Sat, 12 Oct 2019 03:00:25 -0400 Original-Received: from [176.228.60.248] (port=4506 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iJBO4-0006oz-Fo; Sat, 12 Oct 2019 03:00:24 -0400 In-reply-to: <87blun57wt.fsf@kenko.localhost.com> (message from Ingo Lohmar on Fri, 11 Oct 2019 22:44:34 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240901 Archived-At: > From: Ingo Lohmar > Date: Fri, 11 Oct 2019 22:44:34 +0200 > > Since I tested with a minimal example, however, I did not realize before > that there is another code path that directly uses the C function > `set-frame-size', with the same effect: If line-spacing is > 0 in the > frame, it is not accounted for, and the frame lacks a few pixels in > height (number of lines * "line-spacing effect"). > > This appears to be a bug: If asked for a frame N lines tall, N lines (of > default-font's character height plus the effect of line-spacing) should > fit, right? Not necessarily. You didn't tell which command or API exhibits this behavior, but in some cases we mean height in units of the frame's canonical character height, ion which case it doesn't include any effects like line-spacing etc.