From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 28 Nov 2019 17:19:44 +0200 Message-ID: <83o8wwowof.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <87d0dd88jr.fsf@mail.linkov.net> <9b5626e9-5872-cbff-aa3a-16af19ee2fa2@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="75659"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 28 16:41:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iaLun-000JXc-Jj for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Nov 2019 16:41:10 +0100 Original-Received: from localhost ([::1]:50144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaLul-0005U1-9O for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Nov 2019 10:41:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45515) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaLdj-0004Yy-Ry for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 10:23:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaLaQ-0006yo-09 for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 10:20:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iaLaP-0006wd-Ql for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 10:20:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iaLaM-000408-4W for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 10:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Nov 2019 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157495439315360 (code B ref 37774); Thu, 28 Nov 2019 15:20:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 28 Nov 2019 15:19:53 +0000 Original-Received: from localhost ([127.0.0.1]:59008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaLaD-0003zf-Gj for submit@debbugs.gnu.org; Thu, 28 Nov 2019 10:19:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaLaA-0003zQ-9E for 37774@debbugs.gnu.org; Thu, 28 Nov 2019 10:19:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iaLZz-0005Ox-7k; Thu, 28 Nov 2019 10:19:39 -0500 Original-Received: from [176.228.60.248] (port=3796 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iaLZv-0007eP-Ui; Thu, 28 Nov 2019 10:19:37 -0500 In-reply-to: <9b5626e9-5872-cbff-aa3a-16af19ee2fa2@yandex.ru> (message from Dmitry Gutov on Thu, 28 Nov 2019 01:34:08 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172603 Archived-At: > Cc: Eli Zaretskii , 37774@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 28 Nov 2019 01:34:08 +0200 > > > diff-context by default is just '((t nil)) > > Where do you think to add ':extend t'? > > To empty face definition? > > '((t (:extend t))), something like that? Yes. > Good point, though. If it is a good point, I guess I'm missing it. > The theme I'm currently using has this for this face's definition: > > `(diff-context ((,class (:inherit highlight)))) > > (to inherit the color). > > I'm not sure where it'll add the required attribute there. Again, I don't think I understand the difficulty. Suppose you wanted to add an :underline attribute -- would you have a similar difficulty then? > Or if. Up to you, of course. I said long ago that IMO it is/was a mistake to make so many Diff faces extend to EOL.