From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39179: 27.0.50; [PATCH] Add filter to gdb-mi register buffer Date: Fri, 31 Jan 2020 11:56:25 +0200 Message-ID: <83o8ukkkza.fsf@gnu.org> References: <7ADCB299-819A-4D1F-A95A-03655C997E57@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39179@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 31 10:57:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixT31-000PGZ-Ov for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 10:57:11 +0100 Original-Received: from localhost ([::1]:50822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixT30-0008GR-Ob for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 04:57:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43840) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixT2t-0008G7-PR for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 04:57:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixT2s-0002mu-Mw for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 04:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixT2s-0002lg-JZ for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 04:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixT2s-0001yy-HE for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 04:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39179-submit@debbugs.gnu.org id=B39179.15804646147606 (code B ref 39179); Fri, 31 Jan 2020 09:57:02 +0000 Original-Received: (at 39179) by debbugs.gnu.org; 31 Jan 2020 09:56:54 +0000 Original-Received: from localhost ([127.0.0.1]:36591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixT2j-0001yc-RI for submit@debbugs.gnu.org; Fri, 31 Jan 2020 04:56:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixT2i-0001yN-Qq for 39179@debbugs.gnu.org; Fri, 31 Jan 2020 04:56:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixT2d-0001vx-Jr; Fri, 31 Jan 2020 04:56:47 -0500 Original-Received: from [176.228.60.248] (port=1620 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixT2d-0005iS-0V; Fri, 31 Jan 2020 04:56:47 -0500 In-reply-to: <7ADCB299-819A-4D1F-A95A-03655C997E57@gmail.com> (message from Yuan Fu on Sat, 18 Jan 2020 15:51:31 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175478 Archived-At: > From: Yuan Fu > Date: Sat, 18 Jan 2020 15:51:31 -0500 > > On startup, there will be a button “[filter off]” on the header line > of the register buffer. Clicking on it enables the register filter, > changes the button to “[filter on]” and adds a “[-|+]” button next to > it. Click “+” to add patterns to the pattern list, click “-” to > remove. Register whose name matches any pattern in the list is > displayed. You can also use key “f” for toggle, “+” to add pattern, > “-” to remove pattern. I'm not sure it's a good idea to implement this as a button on the header-line. Such buttons are for frequent operations, and also have the disadvantage of being unavailable on TTY frames. What are the chances users will need to redefine the register patters frequently enough to justify the button? Wouldn't it be much easier to have a defcustom whose value users could interactively modify as needed? And please don't use non-ASCII characters in log messages, as these could cause trouble reading the Git log on less capable terminals. > * lisp/progmodes/gdb-mi.el (gdb-registers-enable-filter, > gdb-registers-filter-pattern-list, gdb-header-click-event-handler, > gdb-registers-add-to-display, gdb-registers-remove-from-display, > gdb-registers-toggle-filter): new ^^^ "New functions." > (gdb-registers-handler-custom): condition check before adding each > register > (gdb-registers-mode-map): add new keys > (gdb-registers-header): add new buttons Please start description of changes with a capitalized word, and end with a period -- these should be complete English sentences. > +;; automatically local because we don't want filters persist across gdb sessions Likewise in comments: complete sentences (here and elsewhere in the patch). Thanks.